assert: improve support for new execution contexts

More detailed information in GH-693

diff --git a/lib/assert.js b/lib/assert.js
index f81c203..a2afdcf 100644 (file)
--- a/lib/assert.js
+++ b/lib/assert.js
@@ -277,7 +277,7 @@ function expectedException(actual, expected) {
     return false;
   }
 
-  if (expected instanceof RegExp) {
+  if (Object.prototype.toString.call(expected) == '[object RegExp]') {
     return expected.test(actual);
   } else if (actual instanceof expected) {
     return true;

diff --git a/test/simple/test-script-context.js b/test/simple/test-script-context.js
index f29af23..8095a71 100644 (file)
--- a/test/simple/test-script-context.js
+++ b/test/simple/test-script-context.js
@@ -42,7 +42,6 @@ result = script.runInContext(context);
 assert.equal(3, context.foo);
 assert.equal('lala', context.thing);
 
-
 // Issue GH-227:
 Script.runInNewContext('', null, 'some.js');
 
@@ -69,3 +68,10 @@ function isTypeError(o) {
   assert.throws(function() { script.runInContext(e); }, isTypeError);
   assert.throws(function() { vm.runInContext('', e); }, isTypeError);
 }));
+
+// Issue GH-693:
+common.debug('test RegExp as argument to assert.throws');
+script = vm.createScript('var assert = require(\'assert\'); assert.throws(' +
+                         'function() { throw "hello world"; }, /hello/);',
+                         'some.js');
+script.runInNewContext({ require : require });