PCI: xilinx-cpm: Fix reference count leak on error path
authorPan Bian <bianpan2016@163.com>
Wed, 20 Jan 2021 14:37:45 +0000 (06:37 -0800)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Mon, 25 Jan 2021 17:27:41 +0000 (17:27 +0000)
Also drop the reference count of the node on error path.

Link: https://lore.kernel.org/r/20210120143745.699-1-bianpan2016@163.com
Fixes: 508f610648b9 ("PCI: xilinx-cpm: Add Versal CPM Root Port driver")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
drivers/pci/controller/pcie-xilinx-cpm.c

index f92e015..67937fa 100644 (file)
@@ -404,6 +404,7 @@ static int xilinx_cpm_pcie_init_irq_domain(struct xilinx_cpm_pcie_port *port)
        return 0;
 out:
        xilinx_cpm_free_irq_domains(port);
+       of_node_put(pcie_intc_node);
        dev_err(dev, "Failed to allocate IRQ domains\n");
 
        return -ENOMEM;