2011-02-27 Michael Snyder <msnyder@vmware.com>

	* objc-lang.c (selectors_info): Prevent string overrun.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 941c611..041543b 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,7 @@
 2011-02-27  Michael Snyder  <msnyder@vmware.com>
 
+       * objc-lang.c (selectors_info): Prevent string overrun.
+
        * tui/tui-stack.c (tui_get_function_from_frame): Fix off by one
        error in strncpy.
 

diff --git a/gdb/objc-lang.c b/gdb/objc-lang.c
index 25e13be..d795104 100644 (file)
--- a/gdb/objc-lang.c
+++ b/gdb/objc-lang.c
@@ -720,7 +720,7 @@ selectors_info (char *regexp, int from_tty)
        strcpy(myregexp, ".*]");
       else
        {
-         strcpy(myregexp, regexp);
+         strncpy(myregexp, regexp, sizeof (myregexp) - 1);
          if (myregexp[strlen(myregexp) - 1] == '$') /* end of selector */
            myregexp[strlen(myregexp) - 1] = ']';    /* end of method name */
          else