Revert "[compiler-rt] Make use of undefined symbols configurable"
authorNikita Popov <nikita.ppv@gmail.com>
Tue, 22 Jun 2021 19:17:40 +0000 (21:17 +0200)
committerNikita Popov <nikita.ppv@gmail.com>
Tue, 22 Jun 2021 19:20:20 +0000 (21:20 +0200)
This reverts commit ed7086ad46f99f639b85ea6c8bda7c1a71be7c53.
This reverts commit b9792638b0bfb308e0c7c125ac78f4ebf910c11b.

This breaks cmake with message:

    CMake Error at llvm-project/compiler-rt/CMakeLists.txt:449:
      Parse error.  Expected "(", got newline with text "

compiler-rt/CMakeLists.txt

index c961c7f..5d0e617 100644 (file)
@@ -437,18 +437,10 @@ else()
 endif()
 
 append_list_if(COMPILER_RT_HAS_LIBC c SANITIZER_COMMON_LINK_LIBS)
-if("${CMAKE_SYSTEM_NAME}" STREQUAL "Fuchsia")
-  list(APPEND SANITIZER_COMMON_LINK_LIBS zircon)
-endif()
 
 if("${CMAKE_SYSTEM_NAME}" STREQUAL "Fuchsia")
-  set(SANITIZER_NO_UNDEFINED_SYMBOLS_DEFAULT ON)
-else()
-  set(SANITIZER_NO_UNDEFINED_SYMBOLS_DEFAULT OFF)
-endif
-option(SANITIZER_NO_UNDEFINED_SYMBOLS "Report error on unresolved symbol references" ${SANITIZER_NO_UNDEFINED_SYMBOLS_DEFAULT})
-if (SANITIZER_NO_UNDEFINED_SYMBOLS)
   list(APPEND SANITIZER_COMMON_LINK_FLAGS -Wl,-z,defs)
+  list(APPEND SANITIZER_COMMON_LINK_LIBS zircon)
 endif()
 
 # TODO: COMPILER_RT_COMMON_CFLAGS and COMPILER_RT_COMMON_LINK_FLAGS are