pass: Modify the definition of pass_resource_init/exit() 88/137488/5
authorChanwoo Choi <cw00.choi@samsung.com>
Thu, 6 Jul 2017 05:38:22 +0000 (14:38 +0900)
committerChanwoo Choi <cw00.choi@samsung.com>
Fri, 7 Jul 2017 05:34:04 +0000 (14:34 +0900)
This patch uses the 'struct pass_resource *' on pass_resource_init/exit()
instead of 'struct pass_policy' because the 'struct pass_resource' indicates
each h/w resource. Also, this patch maintains the same format for argument
when calling the pass_resource_*() function.

[Before]
pass_resource_init(struct pass_policy *policy)
pass_resource_exit(struct pass_policy *policy)

[After]
pass_resource_init(struct pass_resource *pass_res)
pass_resource_exit(struct pass_resource *pass_res)

Change-Id: I457f02b6a67df5e5c8b484fdea5f83587a2f9b67
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
src/pass/pass.c

index 7ca0dcacae5f4a14f2018e505217abe6a367d61c..8cf368f83953d7214032ffec82795105a426671b 100644 (file)
@@ -94,18 +94,13 @@ static const struct edbus_method edbus_methods[] = {
  *                PASS interface (Init/Exit)          *
  ******************************************************/
 
-static int pass_resource_init(struct pass_policy *policy)
+static int pass_resource_init(struct pass_resource *pass_res)
 {
-       struct pass_resource *pass_res = to_pass_resource(policy);
+       struct pass_policy *policy = &pass_res->policy;
        int max_freq = 0;
        int ret;
        int i;
 
-       if (!policy) {
-               _E("cannot initialize PASS\n");
-               return -1;
-       }
-
        /*
         * Initialize pass-table by parsing pass.conf
         */
@@ -199,8 +194,9 @@ static int pass_resource_init(struct pass_policy *policy)
        return 0;
 }
 
-static int pass_resource_exit(struct pass_policy *policy)
+static int pass_resource_exit(struct pass_resource *pass_res)
 {
+       struct pass_policy *policy = &pass_res->policy;
        int ret;
 
        pass_put_table(policy);
@@ -242,10 +238,8 @@ static int pass_init_done(void *data, void *user_data)
        /* Initialize pass resources data based on parsed configuration */
        for (i = 0; i < g_pass.num_resources; i++) {
                struct pass_resource *pass_res = &g_pass.res[i];
-               struct pass_policy *policy = &pass_res->policy;
                struct pass_conf_data *cdata = &g_pass.res[i].cdata;
 
-               policy->governor = NULL;
                ret = pass_get_resource(pass_res);
                if (ret < -1) {
                        _E("Cannot get the pass '%s' resource (%d)\n",
@@ -253,7 +247,7 @@ static int pass_init_done(void *data, void *user_data)
                        continue;
                }
 
-               ret = pass_resource_init(policy);
+               ret = pass_resource_init(pass_res);
                if (ret < 0) {
                        _E("Cannot initialize the pass '%s' resource (%d)\n",
                                        cdata->res_name, ret);
@@ -270,10 +264,9 @@ static int pass_exit_done(void)
 
        for (i = 0; i < g_pass.num_resources; i++) {
                struct pass_resource *pass_res = &g_pass.res[i];
-               struct pass_policy *policy = &pass_res->policy;
                struct pass_conf_data *cdata = &g_pass.res[i].cdata;
 
-               ret = pass_resource_exit(policy);
+               ret = pass_resource_exit(pass_res);
                if (ret < 0) {
                        _E("Cannot exit the pass '%s' resource (%d)\n",
                                        cdata->res_name, ret);