rtphdrext: Return non-floating references from `gst_rtp_header_extension_create_from_...
authorSebastian Dröge <sebastian@centricular.com>
Thu, 27 Jan 2022 12:22:26 +0000 (14:22 +0200)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Thu, 27 Jan 2022 14:43:41 +0000 (14:43 +0000)
The header extension objects are never getting a parent object and using
floating references only complicates usage, especially via dynamic API
like signals.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1582>

subprojects/gst-plugins-base/gst-libs/gst/rtp/gstrtphdrext.c

index 1116525..48fdd83 100644 (file)
@@ -858,6 +858,8 @@ gst_rtp_header_extension_create_from_uri (const gchar * uri)
 
     g_list_free_full (l, (GDestroyNotify) gst_object_unref);
 
+    gst_object_ref_sink (element);
+
     return GST_RTP_HEADER_EXTENSION (element);
   }