st/mesa: Deal with empty textures/buffers in semaphore wait/signal.
authorBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Sat, 19 Sep 2020 15:28:17 +0000 (17:28 +0200)
committerMarge Bot <eric+marge@anholt.net>
Tue, 22 Sep 2020 00:14:55 +0000 (00:14 +0000)
The actual texture might not have been created yet.

Gitlab: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3257
CC: mesa-stable
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6788>

src/mesa/state_tracker/st_cb_semaphoreobjects.c

index 51288a8..6d97413 100644 (file)
@@ -109,7 +109,8 @@ st_server_wait_semaphore(struct gl_context *ctx,
          continue;
 
       bufObj = st_buffer_object(bufObjs[i]);
-      pipe->flush_resource(pipe, bufObj->buffer);
+      if (bufObj->buffer)
+         pipe->flush_resource(pipe, bufObj->buffer);
    }
 
    for (unsigned i = 0; i < numTextureBarriers; i++) {
@@ -117,7 +118,8 @@ st_server_wait_semaphore(struct gl_context *ctx,
          continue;
 
       texObj = st_texture_object(texObjs[i]);
-      pipe->flush_resource(pipe, texObj->pt);
+      if (texObj->pt)
+         pipe->flush_resource(pipe, texObj->pt);
    }
 }
 
@@ -141,7 +143,8 @@ st_server_signal_semaphore(struct gl_context *ctx,
          continue;
 
       bufObj = st_buffer_object(bufObjs[i]);
-      pipe->flush_resource(pipe, bufObj->buffer);
+      if (bufObj->buffer)
+         pipe->flush_resource(pipe, bufObj->buffer);
    }
 
    for (unsigned i = 0; i < numTextureBarriers; i++) {
@@ -149,7 +152,8 @@ st_server_signal_semaphore(struct gl_context *ctx,
          continue;
 
       texObj = st_texture_object(texObjs[i]);
-      pipe->flush_resource(pipe, texObj->pt);
+      if (texObj->pt)
+         pipe->flush_resource(pipe, texObj->pt);
    }
 
    /* The driver is allowed to flush during fence_server_signal, be prepared */