https://bugs.webkit.org/show_bug.cgi?id=90226
Reviewed by Martin Robinson.
Source/WebKit/gtk:
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setCSSGridLayoutEnabled): Pass through to Settings object.
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Tools:
This feature is disabled via Settings by default, but for testing,
we enable it using layoutTestController.overridePreferences. Add the
necessary plumbing for DRT.
WTR already works because support was added for Apple Mac earlier.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): Feature is off by default.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::overridePreference): Add handling of WebKitCSSGridLayoutEnabled.
LayoutTests:
* platform/gtk/TestExpectations: Tests should pass.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2012-06-29 Tony Chang <tony@chromium.org>
+
+ [GTK] Enable CSS grid layout LayoutTests on GTK+
+ https://bugs.webkit.org/show_bug.cgi?id=90226
+
+ Reviewed by Martin Robinson.
+
+ * platform/gtk/TestExpectations: Tests should pass.
+
2012-06-29 Stephen White <senorblanco@chromium.org>
Unreviewed gardening.
BUGWKGTK SKIP : http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html = TEXT
BUGWKGTK SKIP : http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html = TEXT
-// CSS Grid Layout is not yet enabled.
-BUGWK60731 : fast/css-grid-layout = TEXT IMAGE
-BUGWK60731 : fast/css-grid-layout/grid-disabled-by-default.html = PASS
-
// <style scoped> is not yet enabled.
BUGWK49142 : fast/css/style-scoped = TEXT
+2012-06-29 Tony Chang <tony@chromium.org>
+
+ [GTK] Enable CSS grid layout LayoutTests on GTK+
+ https://bugs.webkit.org/show_bug.cgi?id=90226
+
+ Reviewed by Martin Robinson.
+
+ * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
+ (DumpRenderTreeSupportGtk::setCSSGridLayoutEnabled): Pass through to Settings object.
+ * WebCoreSupport/DumpRenderTreeSupportGtk.h:
+ (DumpRenderTreeSupportGtk):
+
2012-06-29 Konrad Piascik <kpiascik@rim.com>
Don't hardcode target dpi of 160 (it should be 96 on desktop)
core(webView)->settings()->setPageCacheSupportsPlugins(enabled);
}
+void DumpRenderTreeSupportGtk::setCSSGridLayoutEnabled(WebKitWebView* webView, bool enabled)
+{
+ core(webView)->settings()->setCSSGridLayoutEnabled(enabled);
+}
+
bool DumpRenderTreeSupportGtk::elementDoesAutoCompleteForElementWithId(WebKitWebFrame* frame, JSStringRef id)
{
Frame* coreFrame = core(frame);
static void setHixie76WebSocketProtocolEnabled(WebKitWebView*, bool enabled);
static void setPageCacheSupportsPlugins(WebKitWebView*, bool enabled);
+ static void setCSSGridLayoutEnabled(WebKitWebView*, bool enabled);
static void deliverAllMutationsIfNecessary();
static void setDomainRelaxationForbiddenForURLScheme(bool forbidden, const char* urlScheme);
+2012-06-29 Tony Chang <tony@chromium.org>
+
+ [GTK] Enable CSS grid layout LayoutTests on GTK+
+ https://bugs.webkit.org/show_bug.cgi?id=90226
+
+ Reviewed by Martin Robinson.
+
+ This feature is disabled via Settings by default, but for testing,
+ we enable it using layoutTestController.overridePreferences. Add the
+ necessary plumbing for DRT.
+
+ WTR already works because support was added for Apple Mac earlier.
+
+ * DumpRenderTree/gtk/DumpRenderTree.cpp:
+ (resetDefaultsToConsistentValues): Feature is off by default.
+ * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
+ (LayoutTestController::overridePreference): Add handling of WebKitCSSGridLayoutEnabled.
+
2012-06-29 Ádám Kallai <kadam@inf.u-szeged.hu>
[Qt] Added Qt port for garden-o-matic.
DumpRenderTreeSupportGtk::resetGeolocationClientMock(webView);
DumpRenderTreeSupportGtk::setHixie76WebSocketProtocolEnabled(webView, true);
+ DumpRenderTreeSupportGtk::setCSSGridLayoutEnabled(webView, false);
}
static bool useLongRunningServerMode(int argc, char *argv[])
} else if (g_str_equal(originalName.get(), "WebKitPageCacheSupportsPluginsPreferenceKey")) {
DumpRenderTreeSupportGtk::setPageCacheSupportsPlugins(webkit_web_frame_get_web_view(mainFrame), booleanFromValue(valueAsString.get()));
return;
+ } else if (g_str_equal(originalName.get(), "WebKitCSSGridLayoutEnabled")) {
+ DumpRenderTreeSupportGtk::setCSSGridLayoutEnabled(webkit_web_frame_get_web_view(mainFrame), booleanFromValue(valueAsString.get()));
+ return;
} else {
fprintf(stderr, "LayoutTestController::overridePreference tried to override "
"unknown preference '%s'.\n", originalName.get());