bad: use of g_value_dup_string

Use helper method to get string from GValue.

diff --git a/ext/neon/gstneonhttpsrc.c b/ext/neon/gstneonhttpsrc.c
index ad3a89c..080216d 100644 (file)
--- a/ext/neon/gstneonhttpsrc.c
+++ b/ext/neon/gstneonhttpsrc.c
@@ -321,7 +321,7 @@ gst_neonhttp_src_set_property (GObject * object, guint prop_id,
     }
     case PROP_USER_AGENT:
       g_free (src->user_agent);
-      src->user_agent = g_strdup (g_value_get_string (value));
+      src->user_agent = g_value_dup_string (value);
       break;
     case PROP_COOKIES:
       if (src->cookies)

diff --git a/gst/librfb/gstrfbsrc.c b/gst/librfb/gstrfbsrc.c
index 9c9b5ab..194ee07 100644 (file)
--- a/gst/librfb/gstrfbsrc.c
+++ b/gst/librfb/gstrfbsrc.c
@@ -248,17 +248,17 @@ gst_rfb_src_set_property (GObject * object, guint prop_id,
 
   switch (prop_id) {
     case PROP_HOST:
-      src->host = g_strdup (g_value_get_string (value));
+      src->host = g_value_dup_string (value);;
       break;
     case PROP_PORT:
       src->port = g_value_get_int (value);
       break;
     case PROP_VERSION:
-      gst_rfb_property_set_version (src, g_strdup (g_value_get_string (value)));
+      gst_rfb_property_set_version (src, g_value_dup_string (value));
       break;
     case PROP_PASSWORD:
       g_free (src->decoder->password);
-      src->decoder->password = g_strdup (g_value_get_string (value));
+      src->decoder->password = g_value_dup_string (value);
       break;
     case PROP_OFFSET_X:
       src->decoder->offset_x = g_value_get_int (value);

diff --git a/sys/directsound/gstdirectsoundsrc.c b/sys/directsound/gstdirectsoundsrc.c
index f176faf..82a3480 100644 (file)
--- a/sys/directsound/gstdirectsoundsrc.c
+++ b/sys/directsound/gstdirectsoundsrc.c
@@ -262,7 +262,7 @@ gst_directsound_src_set_property (GObject * object, guint prop_id,
         src->device_name = NULL;
       }
       if (g_value_get_string (value)) {
-        src->device_name = g_strdup (g_value_get_string (value));
+        src->device_name = g_value_dup_string (value);
       }
       break;
     case PROP_VOLUME:

diff --git a/sys/dshowsrcwrapper/gstdshowaudiosrc.cpp b/sys/dshowsrcwrapper/gstdshowaudiosrc.cpp
index f69799f..f2ffc7a 100644 (file)
--- a/sys/dshowsrcwrapper/gstdshowaudiosrc.cpp
+++ b/sys/dshowsrcwrapper/gstdshowaudiosrc.cpp
@@ -220,7 +220,7 @@ gst_dshowaudiosrc_set_property (GObject * object, guint prop_id,
         src->device = NULL;
       }
       if (g_value_get_string (value)) {
-        src->device = g_strdup (g_value_get_string (value));
+        src->device = g_value_dup_string (value);;
       }
       break;
     }
@@ -231,7 +231,7 @@ gst_dshowaudiosrc_set_property (GObject * object, guint prop_id,
         src->device_name = NULL;
       }
       if (g_value_get_string (value)) {
-        src->device_name = g_strdup (g_value_get_string (value));
+        src->device_name = g_value_dup_string (value);;
       }
       break;
     }