drm/ttm: Simplify ttm_dma_find_pool() (v2)
authorTom St Denis <tom.stdenis@amd.com>
Thu, 25 Jan 2018 18:52:30 +0000 (13:52 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 19 Feb 2018 19:18:58 +0000 (14:18 -0500)
Flip the logic of the comparison and remove
the redudant variable for the pool address.

(v2): Remove {} bracing.

Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c

index 647eb5f..469e68e 100644 (file)
@@ -682,10 +682,10 @@ err_mem:
 static struct dma_pool *ttm_dma_find_pool(struct device *dev,
                                          enum pool_type type)
 {
-       struct dma_pool *pool, *tmp, *found = NULL;
+       struct dma_pool *pool, *tmp;
 
        if (type == IS_UNDEFINED)
-               return found;
+               return NULL;
 
        /* NB: We iterate on the 'struct dev' which has no spinlock, but
         * it does have a kref which we have taken. The kref is taken during
@@ -698,13 +698,10 @@ static struct dma_pool *ttm_dma_find_pool(struct device *dev,
         * thing is at that point of time there are no pages associated with the
         * driver so this function will not be called.
         */
-       list_for_each_entry_safe(pool, tmp, &dev->dma_pools, pools) {
-               if (pool->type != type)
-                       continue;
-               found = pool;
-               break;
-       }
-       return found;
+       list_for_each_entry_safe(pool, tmp, &dev->dma_pools, pools)
+               if (pool->type == type)
+                       return pool;
+       return NULL;
 }
 
 /*