net: smsc: Use pci_dev_id() to simplify the code
authorZheng Zengkai <zhengzengkai@huawei.com>
Fri, 11 Aug 2023 11:07:00 +0000 (19:07 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 13 Aug 2023 11:30:39 +0000 (12:30 +0100)
PCI core API pci_dev_id() can be used to get the BDF number for a pci
device. We don't need to compose it manually. Use pci_dev_id() to
simplify the code a little bit.

Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/smsc/smsc9420.c

index 3b26f1d..e1c4a11 100644 (file)
@@ -1144,8 +1144,7 @@ static int smsc9420_mii_init(struct net_device *dev)
                goto err_out_1;
        }
        pd->mii_bus->name = DRV_MDIONAME;
-       snprintf(pd->mii_bus->id, MII_BUS_ID_SIZE, "%x",
-               (pd->pdev->bus->number << 8) | pd->pdev->devfn);
+       snprintf(pd->mii_bus->id, MII_BUS_ID_SIZE, "%x", pci_dev_id(pd->pdev));
        pd->mii_bus->priv = pd;
        pd->mii_bus->read = smsc9420_mii_read;
        pd->mii_bus->write = smsc9420_mii_write;