scsi: scsi_error: DID_SOFT_ERROR comment clean up
authorPetros Koutoupis <petros@petroskoutoupis.com>
Mon, 30 Oct 2017 21:38:10 +0000 (16:38 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 3 Nov 2017 15:23:30 +0000 (11:23 -0400)
Updated comment. We are keeping track of maximum number of retries per
command via retries/allowed in struct scsi_cmnd. Corrected comment
positioning.

[mkp: applied by hand]

Signed-off-by: Petros Koutoupis <petros@petroskoutoupis.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_error.c

index d670027..ae04863 100644 (file)
@@ -1753,16 +1753,12 @@ int scsi_decide_disposition(struct scsi_cmnd *scmd)
                 * that it indicates SUCCESS.
                 */
                return SUCCESS;
+       case DID_SOFT_ERROR:
                /*
                 * when the low level driver returns did_soft_error,
                 * it is responsible for keeping an internal retry counter
                 * in order to avoid endless loops (db)
-                *
-                * actually this is a bug in this function here.  we should
-                * be mindful of the maximum number of retries specified
-                * and not get stuck in a loop.
                 */
-       case DID_SOFT_ERROR:
                goto maybe_retry;
        case DID_IMM_RETRY:
                return NEEDS_RETRY;