pvr: Update comment about ZS and MSAA buffers for pvrsrvkm submission.
authorKarmjit Mahil <Karmjit.Mahil@imgtec.com>
Tue, 29 Nov 2022 16:08:03 +0000 (16:08 +0000)
committerMarge Bot <emma+marge@anholt.net>
Mon, 6 Feb 2023 10:47:38 +0000 (10:47 +0000)
Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21102>

src/imagination/vulkan/winsys/pvrsrvkm/pvr_srv_job_render.c

index 64e9f43..4b56c4a 100644 (file)
@@ -766,6 +766,12 @@ VkResult pvr_srv_winsys_render_submit(
    sync_prim->value++;
 
    do {
+      /* The fw allows the ZS and MSAA scratch buffers to be lazily allocated in
+       * which case we need to provide a status update (i.e. if they are
+       * physically backed or not) to the fw. In our case they will always be
+       * physically backed so no need to inform the fw about their status and
+       * pass in anything. We'll just pass in NULL.
+       */
       result = pvr_srv_rgx_kick_render2(srv_ws->render_fd,
                                         srv_ctx->handle,
                                         0,
@@ -808,9 +814,7 @@ VkResult pvr_srv_winsys_render_submit(
                                         false,
                                         0,
                                         rt_data_handle,
-                                        /* Currently no support for PRs. */
                                         NULL,
-                                        /* Currently no support for PRs. */
                                         NULL,
                                         0,
                                         NULL,