mtd: rawnand: meson: Fix a resource leak in init
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 3 Dec 2020 08:39:48 +0000 (11:39 +0300)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 10 Dec 2020 21:37:33 +0000 (22:37 +0100)
Call clk_disable_unprepare(nfc->phase_rx) if the clk_set_rate() function
fails to avoid a resource leak.

Fixes: 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/X8ikVCnUsfTpffFB@mwanda
drivers/mtd/nand/raw/meson_nand.c

index a76afea..817bddc 100644 (file)
@@ -1044,9 +1044,12 @@ static int meson_nfc_clk_init(struct meson_nfc *nfc)
 
        ret = clk_set_rate(nfc->device_clk, 24000000);
        if (ret)
-               goto err_phase_rx;
+               goto err_disable_rx;
 
        return 0;
+
+err_disable_rx:
+       clk_disable_unprepare(nfc->phase_rx);
 err_phase_rx:
        clk_disable_unprepare(nfc->phase_tx);
 err_phase_tx: