firmware: imx: scu: Fix possible memory leak in imx_scu_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 6 May 2020 05:14:10 +0000 (05:14 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Jun 2020 15:50:30 +0000 (17:50 +0200)
[ Upstream commit 89f12d6509bff004852c51cb713a439a86816b24 ]

'chan_name' is malloced in imx_scu_probe() and should be freed
before leaving from the error handling cases, otherwise it will
cause memory leak.

Fixes: edbee095fafb ("firmware: imx: add SCU firmware driver support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/firmware/imx/imx-scu.c

index e48d971..a3b11bc 100644 (file)
@@ -300,6 +300,7 @@ static int imx_scu_probe(struct platform_device *pdev)
                        if (ret != -EPROBE_DEFER)
                                dev_err(dev, "Failed to request mbox chan %s ret %d\n",
                                        chan_name, ret);
+                       kfree(chan_name);
                        return ret;
                }