dm writecache: commit just one block, not a full page
authorMikulas Patocka <mpatocka@redhat.com>
Sun, 6 Jun 2021 20:13:16 +0000 (16:13 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jul 2021 07:44:50 +0000 (09:44 +0200)
[ Upstream commit 991bd8d7bc78966b4dc427b53a144f276bffcd52 ]

Some architectures have pages larger than 4k and committing a full
page causes needless overhead.

Fix this by writing a single block when committing the superblock.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/md/dm-writecache.c

index 64c2980..894b58b 100644 (file)
@@ -532,11 +532,7 @@ static void ssd_commit_superblock(struct dm_writecache *wc)
 
        region.bdev = wc->ssd_dev->bdev;
        region.sector = 0;
-       region.count = PAGE_SIZE >> SECTOR_SHIFT;
-
-       if (unlikely(region.sector + region.count > wc->metadata_sectors))
-               region.count = wc->metadata_sectors - region.sector;
-
+       region.count = wc->block_size >> SECTOR_SHIFT;
        region.sector += wc->start_sector;
 
        req.bi_op = REQ_OP_WRITE;