pinctrl: npcm7xx: Add missing check for ioremap
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Wed, 7 Jun 2023 09:58:29 +0000 (17:58 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 9 Jun 2023 07:42:52 +0000 (09:42 +0200)
Add check for ioremap() and return the error if it fails in order to
guarantee the success of ioremap().

Fixes: 3b588e43ee5c ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20230607095829.1345-1-jiasheng@iscas.ac.cn
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c

index 21e61c2..843ffcd 100644 (file)
@@ -1884,6 +1884,8 @@ static int npcm7xx_gpio_of(struct npcm7xx_pinctrl *pctrl)
                }
 
                pctrl->gpio_bank[id].base = ioremap(res.start, resource_size(&res));
+               if (!pctrl->gpio_bank[id].base)
+                       return -EINVAL;
 
                ret = bgpio_init(&pctrl->gpio_bank[id].gc, dev, 4,
                                 pctrl->gpio_bank[id].base + NPCM7XX_GP_N_DIN,