ext4: remove unnecessary return for void function
authorKemeng Shi <shikemeng@huaweicloud.com>
Tue, 1 Aug 2023 14:31:59 +0000 (22:31 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 3 Aug 2023 14:47:30 +0000 (10:47 -0400)
The return at end of void function is unnecessary, just remove it.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Link: https://lore.kernel.org/r/20230801143204.2284343-6-shikemeng@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/mballoc.c

index 3dd2609..154ae1f 100644 (file)
@@ -4976,7 +4976,6 @@ static void ext4_mb_generate_from_freelist(struct super_block *sb, void *bitmap,
                mb_set_bits(bitmap, entry->efd_start_cluster, entry->efd_count);
                n = rb_next(n);
        }
-       return;
 }
 
 /*
@@ -5727,12 +5726,10 @@ static void ext4_mb_show_ac(struct ext4_allocation_context *ac)
 #else
 static inline void ext4_mb_show_pa(struct super_block *sb)
 {
-       return;
 }
 static inline void ext4_mb_show_ac(struct ext4_allocation_context *ac)
 {
        ext4_mb_show_pa(ac->ac_sb);
-       return;
 }
 #endif
 
@@ -5973,12 +5970,9 @@ static void ext4_mb_add_n_trim(struct ext4_allocation_context *ac)
        spin_unlock(&lg->lg_prealloc_lock);
 
        /* Now trim the list to be not more than 8 elements */
-       if (lg_prealloc_count > 8) {
+       if (lg_prealloc_count > 8)
                ext4_mb_discard_lg_preallocations(sb, lg,
                                                  order, lg_prealloc_count);
-               return;
-       }
-       return ;
 }
 
 /*
@@ -6632,7 +6626,6 @@ do_more:
 error_return:
        brelse(bitmap_bh);
        ext4_std_error(sb, err);
-       return;
 }
 
 /**
@@ -6735,7 +6728,6 @@ void ext4_free_blocks(handle_t *handle, struct inode *inode,
        }
 
        ext4_mb_clear_bb(handle, inode, block, count, flags);
-       return;
 }
 
 /**