ges: Calm logging when not created TrackObject on purpose

diff --git a/ges/ges-timeline-standard-transition.c b/ges/ges-timeline-standard-transition.c
index b2e2b71504f921a56485bc6215641c42fb445789..1741eecbbcaf831d07652801fcb280c0ebdf44f1 100644 (file)
--- a/ges/ges-timeline-standard-transition.c
+++ b/ges/ges-timeline-standard-transition.c
@@ -191,29 +191,37 @@ ges_tl_transition_create_track_object (GESTimelineObject * obj,
 {
   GESTimelineStandardTransition *transition =
       (GESTimelineStandardTransition *) obj;
-  GESTrackObject *res;
+  GESTrackObject *res = NULL;
   GESTrackType supportedformats;
 
   GST_DEBUG ("Creating a GESTrackTransition");
 
   supportedformats = ges_timeline_object_get_supported_formats (obj);
-  if (track->type == GES_TRACK_TYPE_VIDEO &&
-      (supportedformats == GES_TRACK_TYPE_UNKNOWN ||
-          supportedformats & GES_TRACK_TYPE_VIDEO)) {
-    res = GES_TRACK_OBJECT (ges_track_video_transition_new ());
-    ges_track_video_transition_set_transition_type ((GESTrackVideoTransition *)
-        res, transition->vtype);
-
-  } else if (track->type == GES_TRACK_TYPE_AUDIO &&
-      (supportedformats == GES_TRACK_TYPE_UNKNOWN ||
-          supportedformats & GES_TRACK_TYPE_AUDIO)) {
-    res = GES_TRACK_OBJECT (ges_track_audio_transition_new ());
-  }
-
-  else {
+  if (track->type == GES_TRACK_TYPE_VIDEO) {
+    if (supportedformats == GES_TRACK_TYPE_UNKNOWN ||
+        supportedformats & GES_TRACK_TYPE_VIDEO) {
+      GESTrackVideoTransition *trans;
+
+      trans = ges_track_video_transition_new ();
+      ges_track_video_transition_set_transition_type (trans, transition->vtype);
+
+      res = GES_TRACK_OBJECT (trans);
+    } else {
+      GST_DEBUG ("Not creating transition as video track not on"
+          " supportedformats");
+    }
+
+  } else if (track->type == GES_TRACK_TYPE_AUDIO) {
+
+    if (supportedformats == GES_TRACK_TYPE_UNKNOWN ||
+        supportedformats & GES_TRACK_TYPE_AUDIO)
+      res = GES_TRACK_OBJECT (ges_track_audio_transition_new ());
+    else
+      GST_DEBUG ("Not creating transition as audio track"
+          " not on supportedformats");
+
+  } else
     GST_WARNING ("Transitions don't handle this track type");
-    return NULL;
-  }
 
   return res;
 }

diff --git a/ges/ges-timeline.c b/ges/ges-timeline.c
index 6d210c18514ed3fd07fc72ca3461ede65b803be6..24ed5ef016c03f88a9f4529defddeb9e721cf8e8 100644 (file)
--- a/ges/ges-timeline.c
+++ b/ges/ges-timeline.c
@@ -329,7 +329,9 @@ static void
 add_object_to_track (GESTimelineObject * object, GESTrack * track)
 {
   if (!ges_timeline_object_create_track_objects (object, track)) {
-    GST_WARNING ("error creating track objects");
+    if ((track->type & ges_timeline_object_get_supported_formats (object))) {
+      GST_WARNING ("Error creating track objects");
+    }
   }
 }