mpls: Remove redundant assignment to err
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Tue, 27 Apr 2021 10:30:56 +0000 (18:30 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 27 Apr 2021 21:17:00 +0000 (14:17 -0700)
Variable err is set to -ENOMEM but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Cleans up the following clang-analyzer warning:

net/mpls/af_mpls.c:1022:2: warning: Value stored to 'err' is never read
[clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mpls/af_mpls.c

index 47bab70..05a21dd 100644 (file)
@@ -1019,7 +1019,6 @@ static int mpls_route_add(struct mpls_route_config *cfg,
                goto errout;
        }
 
-       err = -ENOMEM;
        rt = mpls_rt_alloc(nhs, max_via_alen, max_labels);
        if (IS_ERR(rt)) {
                err = PTR_ERR(rt);