va: decoder: warn if decode fails on a surface

Instead of logging error if a step fails, it logs a warning message
reducing the noise and obeying the rule for errors since the program
doesn't end

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1584>

diff --git a/sys/va/gstvadecoder.c b/sys/va/gstvadecoder.c
index af53517..ec150ee 100644 (file)
--- a/sys/va/gstvadecoder.c
+++ b/sys/va/gstvadecoder.c
@@ -582,7 +582,7 @@ gst_va_decoder_decode (GstVaDecoder * self, GstVaDecodePicture * pic)
   status = vaBeginPicture (dpy, self->context, pic->surface);
   gst_va_display_unlock (self->display);
   if (status != VA_STATUS_SUCCESS) {
-    GST_ERROR_OBJECT (self, "vaBeginPicture: %s", vaErrorStr (status));
+    GST_WARNING_OBJECT (self, "vaBeginPicture: %s", vaErrorStr (status));
     goto fail_end_pic;
   }
 
@@ -591,7 +591,7 @@ gst_va_decoder_decode (GstVaDecoder * self, GstVaDecodePicture * pic)
       (VABufferID *) pic->buffers->data, pic->buffers->len);
   gst_va_display_unlock (self->display);
   if (status != VA_STATUS_SUCCESS) {
-    GST_ERROR_OBJECT (self, "vaRenderPicture: %s", vaErrorStr (status));
+    GST_WARNING_OBJECT (self, "vaRenderPicture: %s", vaErrorStr (status));
     goto fail_end_pic;
   }
 
@@ -600,7 +600,7 @@ gst_va_decoder_decode (GstVaDecoder * self, GstVaDecodePicture * pic)
       (VABufferID *) pic->slices->data, pic->slices->len);
   gst_va_display_unlock (self->display);
   if (status != VA_STATUS_SUCCESS) {
-    GST_ERROR_OBJECT (self, "vaRenderPicture: %s", vaErrorStr (status));
+    GST_WARNING_OBJECT (self, "vaRenderPicture: %s", vaErrorStr (status));
     goto fail_end_pic;
   }
 
@@ -608,7 +608,7 @@ gst_va_decoder_decode (GstVaDecoder * self, GstVaDecodePicture * pic)
   status = vaEndPicture (dpy, self->context);
   gst_va_display_unlock (self->display);
   if (status != VA_STATUS_SUCCESS) {
-    GST_ERROR_OBJECT (self, "vaEndPicture: %s", vaErrorStr (status));
+    GST_WARNING_OBJECT (self, "vaEndPicture: %s", vaErrorStr (status));
     goto bail;
   }
 
@@ -624,8 +624,6 @@ fail_end_pic:
     gst_va_display_lock (self->display);
     status = vaEndPicture (dpy, self->context);
     gst_va_display_unlock (self->display);
-    if (status != VA_STATUS_SUCCESS)
-      GST_ERROR_OBJECT (self, "vaEndPicture: %s", vaErrorStr (status));
     goto bail;
   }
 }