mtd: rawnand: fsl_ifc: fix probe function error path

An error after nand_scan_tail() should trigger a nand_cleanup().
The helper mtd_device_parse_register() returns an error code that should
be checked and nand_cleanup() called accordingly.

However, in this driver, fsl_ifc_chip_remove() which is called upon
error already triggers a nand_release() which is wrong, because a
nand_release() should be triggered only if an mtd_register() succeeded.

Move the nand_release() call out of the fsl_ifc_chip_remove() and put it
back in the *_remove() hook.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

diff --git a/drivers/mtd/nand/raw/fsl_ifc_nand.c b/drivers/mtd/nand/raw/fsl_ifc_nand.c
index 61aae02..00a609d 100644 (file)
--- a/drivers/mtd/nand/raw/fsl_ifc_nand.c
+++ b/drivers/mtd/nand/raw/fsl_ifc_nand.c
@@ -924,8 +924,6 @@ static int fsl_ifc_chip_remove(struct fsl_ifc_mtd *priv)
 {
        struct mtd_info *mtd = nand_to_mtd(&priv->chip);
 
-       nand_release(mtd);
-
        kfree(mtd->name);
 
        if (priv->vbase)
@@ -1059,21 +1057,29 @@ static int fsl_ifc_nand_probe(struct platform_device *dev)
 
        /* First look for RedBoot table or partitions on the command
         * line, these take precedence over device tree information */
-       mtd_device_parse_register(mtd, part_probe_types, NULL, NULL, 0);
+       ret = mtd_device_parse_register(mtd, part_probe_types, NULL, NULL, 0);
+       if (ret)
+               goto cleanup_nand;
 
        dev_info(priv->dev, "IFC NAND device at 0x%llx, bank %d\n",
                 (unsigned long long)res.start, priv->bank);
+
        return 0;
 
+cleanup_nand:
+       nand_cleanup(&priv->chip);
 err:
        fsl_ifc_chip_remove(priv);
+
        return ret;
 }
 
 static int fsl_ifc_nand_remove(struct platform_device *dev)
 {
        struct fsl_ifc_mtd *priv = dev_get_drvdata(&dev->dev);
+       struct mtd_info *mtd = nand_to_mtd(&priv->chip);
 
+       nand_release(mtd);
        fsl_ifc_chip_remove(priv);
 
        mutex_lock(&fsl_ifc_nand_mutex);