video: fbdev: controlfb: fix warnings about comparing pointer to 0

Fix warnings aboout comparing pointer to 0 reported by coccicheck:

drivers/video/fbdev/controlfb.c: WARNING comparing pointer to 0
drivers/video/fbdev/controlfb.c: WARNING comparing pointer to 0
drivers/video/fbdev/controlfb.c: WARNING comparing pointer to 0

Also while at it change return value to -ENOMEM on kzalloc() failure.

Signed-off-by: Shobhit Kukreti <shobhitkukreti@gmail.com>
Reviewed-by: Mathieu Malaterre <malat@debian.org>
[b.zolnierkie: minor fixups]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

diff --git a/drivers/video/fbdev/controlfb.c b/drivers/video/fbdev/controlfb.c
index 7af8db2..9a680ef 100644 (file)
--- a/drivers/video/fbdev/controlfb.c
+++ b/drivers/video/fbdev/controlfb.c
@@ -182,7 +182,7 @@ int init_module(void)
        int ret = -ENXIO;
 
        dp = of_find_node_by_name(NULL, "control");
-       if (dp != 0 && !control_of_init(dp))
+       if (dp && !control_of_init(dp))
                ret = 0;
        of_node_put(dp);
 
@@ -580,7 +580,7 @@ static int __init control_init(void)
        control_setup(option);
 
        dp = of_find_node_by_name(NULL, "control");
-       if (dp != 0 && !control_of_init(dp))
+       if (dp && !control_of_init(dp))
                ret = 0;
        of_node_put(dp);
 
@@ -683,8 +683,8 @@ static int __init control_of_init(struct device_node *dp)
                return -ENXIO;
        }
        p = kzalloc(sizeof(*p), GFP_KERNEL);
-       if (p == 0)
-               return -ENXIO;
+       if (!p)
+               return -ENOMEM;
        control_fb = p; /* save it for cleanups */
 
        /* Map in frame buffer and registers */