GL43: Use zero for DrawArraysIndirectCommand reserved field
authorAlejandro Piñeiro <apinheiro@igalia.com>
Thu, 26 Sep 2019 09:29:42 +0000 (11:29 +0200)
committerAlexander Galazin <Alexander.Galazin@arm.com>
Tue, 8 Oct 2019 08:01:28 +0000 (04:01 -0400)
The test negative-gshIncompatible-arrays is using a non-zero value for
the DrawArraysIndirectCommand reserved field, but quoting its Title,
Purpose and Method:

 "Negative: incompatible the input primitive type of gsh - glDrawArrayIndirect";

 "Verify that a driver sets error and no driver crash occurred";

 "1. Bind non-zero buffer"
 "2. Set data"
 "3. Set wrong geometry shader"
 "4. Call glDrawArrayIndirect"

Testing non-zero values for the reserved field is not one of its
objectives. This seems a C&P error.

Components: OpenGL

VK-GL-CTS issue: 2023

Affects:
KHR-GL43.draw_indirect.negative-gshIncompatible-arrays

Change-Id: I8f0676b3a82266fa41becdfb720b04893720b6fc

external/openglcts/modules/gles31/es31cDrawIndirectTests.cpp

index 8a947d9..265577e 100644 (file)
@@ -7168,7 +7168,7 @@ public:
                indirectArrays.count                                     = static_cast<GLuint>(coords.size());
                indirectArrays.primCount                                 = 1;
                indirectArrays.first                                     = 0;
-               indirectArrays.reservedMustBeZero                = 2312;
+               indirectArrays.reservedMustBeZero                = 0;
 
                glGenBuffers(1, &_bufferIndirect);
                glBindBuffer(GL_DRAW_INDIRECT_BUFFER, _bufferIndirect);