lib/ref_tracker: remove warnings in case of allocation failure
authorAndrzej Hajda <andrzej.hajda@intel.com>
Fri, 2 Jun 2023 10:21:36 +0000 (12:21 +0200)
committerJakub Kicinski <kuba@kernel.org>
Mon, 5 Jun 2023 22:28:42 +0000 (15:28 -0700)
Library can handle allocation failures. To avoid allocation warnings
__GFP_NOWARN has been added everywhere. Moreover GFP_ATOMIC has been
replaced with GFP_NOWAIT in case of stack allocation on tracker free
call.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
lib/ref_tracker.c

index cce4614..cf5609b 100644 (file)
@@ -189,7 +189,7 @@ int ref_tracker_alloc(struct ref_tracker_dir *dir,
        unsigned long entries[REF_TRACKER_STACK_ENTRIES];
        struct ref_tracker *tracker;
        unsigned int nr_entries;
-       gfp_t gfp_mask = gfp;
+       gfp_t gfp_mask = gfp | __GFP_NOWARN;
        unsigned long flags;
 
        WARN_ON_ONCE(dir->dead);
@@ -237,7 +237,8 @@ int ref_tracker_free(struct ref_tracker_dir *dir,
                return -EEXIST;
        }
        nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
-       stack_handle = stack_depot_save(entries, nr_entries, GFP_ATOMIC);
+       stack_handle = stack_depot_save(entries, nr_entries,
+                                       GFP_NOWAIT | __GFP_NOWARN);
 
        spin_lock_irqsave(&dir->lock, flags);
        if (tracker->dead) {