Fix WebTCT auto/manual canvas failures

Goal is to not accelerate small size canvases, so,
AcceleratedSmallCanvasesEnabled() should be false for small size canvases.
Initially, above flag value is changing again to true even after setting
it as false. This commit fixes the same.

This commit fixes below canvas tcs:
[Auto]
1) 2d.imageData.get.source.outside.html
2) 2d.path.arc.selfintersect.1.html

[Manual]
1) 2d.gradient.interpole.zerosize.fillText
2) 2d.gradient.interpole.zerosize.strokeText

Change-Id: I41905eccb6bb11058645da463ef5bcbae44f4386
Signed-off-by: Satyaveer Singh <satyaveer.s@samsung.com>

diff --git a/content/child/runtime_features.cc b/content/child/runtime_features.cc
index bb42e7df8833c6168b106e85d77f58c63c2030cd..7eb2ac1c66592b5a7eb219821cce484764e272e1 100644 (file)
--- a/content/child/runtime_features.cc
+++ b/content/child/runtime_features.cc
@@ -119,10 +119,6 @@ void SetRuntimeFeatureDefaultsForPlatform(
 #if BUILDFLAG(IS_EFL)
   // No plan to support complex UI for date/time INPUT types.
   WebRuntimeFeatures::EnableInputMultipleFieldsUI(false);
-
-  // Small accelerated 2d canvas has tct issues, which are known in
-  // upstream version also.
-  WebRuntimeFeatures::EnableAcceleratedSmallCanvases(false);
 #endif
 }
 

diff --git a/third_party/blink/public/platform/web_runtime_features.h b/third_party/blink/public/platform/web_runtime_features.h
index 4e3edfb54447c75123e218f4f40314cf889971e8..371c5cb6ccbdfcd60255b42e85190b36fae2edb0 100644 (file)
--- a/third_party/blink/public/platform/web_runtime_features.h
+++ b/third_party/blink/public/platform/web_runtime_features.h
@@ -70,7 +70,6 @@ class BLINK_PLATFORM_EXPORT WebRuntimeFeatures : public WebRuntimeFeaturesBase {
   static void EnableFluentOverlayScrollbars(bool);
 #if BUILDFLAG(IS_EFL)
   static void EnableInputMultipleFieldsUI(bool);
-  static void EnableAcceleratedSmallCanvases(bool);
   BLINK_PLATFORM_EXPORT static void SetTizenCompatibilityModeEnabled(bool);
 #endif
 

diff --git a/third_party/blink/renderer/core/exported/web_view_impl.cc b/third_party/blink/renderer/core/exported/web_view_impl.cc
index 5489e4ff5174ca5b45ee00b3d95d19e179a7e6e8..6ff9d0d6559ca893696ee164b849a4cc0a45d1a8 100644 (file)
--- a/third_party/blink/renderer/core/exported/web_view_impl.cc
+++ b/third_party/blink/renderer/core/exported/web_view_impl.cc
@@ -1808,6 +1808,9 @@ void WebView::ApplyWebPreferences(const web_pref::WebPreferences& prefs,
   web_view_impl->SetIgnoreViewportTagScaleLimits(prefs.force_enable_zoom);
   settings->SetLoadWithOverviewMode(prefs.shrinks_viewport_contents_to_fit);
   settings->SetUsesEncodingDetector(prefs.uses_encoding_detector);
+  // Small accelerated 2d canvas has tct issues, which are known in
+  // upstream version also.
+  RuntimeEnabledFeatures::SetAcceleratedSmallCanvasesEnabled(false);
 #endif
 
 #if BUILDFLAG(IS_TIZEN)

diff --git a/third_party/blink/renderer/platform/exported/web_runtime_features.cc b/third_party/blink/renderer/platform/exported/web_runtime_features.cc
index a86b798ad82093b533bcf7c9eb1881d5a111db31..72667d9c785999edcdea6a3e1cbfbf8777906530 100644 (file)
--- a/third_party/blink/renderer/platform/exported/web_runtime_features.cc
+++ b/third_party/blink/renderer/platform/exported/web_runtime_features.cc
@@ -74,10 +74,6 @@ void WebRuntimeFeatures::EnableInputMultipleFieldsUI(bool enable) {
   RuntimeEnabledFeatures::SetInputMultipleFieldsUIEnabled(enable);
 }
 
-void WebRuntimeFeatures::EnableAcceleratedSmallCanvases(bool enable) {
-  RuntimeEnabledFeatures::SetAcceleratedSmallCanvasesEnabled(enable);
-}
-
 void WebRuntimeFeatures::SetTizenCompatibilityModeEnabled(bool enable) {
   RuntimeEnabledFeatures::SetTizenCompatibilityModeEnabled(enable);
 }