tests: parse-launch: looks clean nowadays, so re-enable for valgrind
authorTim-Philipp Müller <tim@centricular.com>
Mon, 26 Sep 2016 11:12:12 +0000 (12:12 +0100)
committerTim-Philipp Müller <tim@centricular.com>
Mon, 26 Sep 2016 11:12:12 +0000 (12:12 +0100)
Also, the valgrind bits weren't hooked up properly anyway,
checking the wrong define.

tests/check/Makefile.am
tests/check/pipelines/parse-launch.c

index 511a60a..1b0ebc4 100644 (file)
@@ -234,7 +234,6 @@ libs_gstnettimeprovider_LDADD = \
 VALGRIND_TO_FIX = \
        gst/gstinfo \
        gst/gsttracerrecord \
-       pipelines/parse-launch \
        tools/gstinspect
 
 VALGRIND_IGNORE = \
index ec30d9c..6472070 100644 (file)
 #  include "config.h"
 #endif
 
-#ifdef HAVE_VALGRIND_H
-# include <valgrind/valgrind.h>
-# include <valgrind/memcheck.h>
-#endif
-
 #include <gst/check/gstcheck.h>
 
 #define GST_TYPE_PARSE_TEST_ELEMENT (gst_parse_test_element_get_type())
@@ -397,19 +392,14 @@ static const gchar *leaking_failures[] = {
   NULL
 };
 
+/* These don't seem to leak any longer? */
 GST_START_TEST (leaking_fail_pipes)
 {
   const gchar **s;
 
   for (s = leaking_failures; *s != NULL; s++) {
-    /* Uncomment if you want to try fixing the leaks */
-#if 0
-    g_print ("Trying pipe: %s\n", *s);
+    GST_INFO ("Trying pipe: %s", *s);
     expected_fail_pipe (*s);
-#endif
-#ifdef HAVE_VALGRIND_H
-    VALGRIND_DO_LEAK_CHECK;
-#endif
   }
 }