x264enc: Don't set an allocation maximum
authorNicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Sun, 18 Jan 2015 16:07:43 +0000 (11:07 -0500)
committerNicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Sun, 18 Jan 2015 16:07:43 +0000 (11:07 -0500)
There is no reason x264enc should enforce a maximum allocation size.
The maximum is normally set by buffer pool which cannot grow, but we
don't offer a buffer pool. This would lead to stall when used with
element that don't implement allocation query.

Related to: https://bugzilla.gnome.org/show_bug.cgi?id=738302

ext/x264/gstx264enc.c

index a5a1e41fa4233bad6d8c50888c15e0665ed9443e..dd37c702ce986d0106e67d3ed3ab459767d46265 100644 (file)
@@ -1932,8 +1932,7 @@ gst_x264_enc_propose_allocation (GstVideoEncoder * encoder, GstQuery * query)
   info = &self->input_state->info;
   num_buffers = x264_encoder_maximum_delayed_frames (self->x264enc) + 1;
 
-  gst_query_add_allocation_pool (query, NULL, info->size, num_buffers,
-      num_buffers);
+  gst_query_add_allocation_pool (query, NULL, info->size, num_buffers, 0);
 
   return GST_VIDEO_ENCODER_CLASS (parent_class)->propose_allocation (encoder,
       query);