ASoC: wm_adsp: Let soc_cleanup_component_debugfs remove debugfs
authorLucas Tanure <tanureal@opensource.cirrus.com>
Wed, 28 Jul 2021 10:44:16 +0000 (11:44 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 28 Jul 2021 15:39:15 +0000 (16:39 +0100)
soc_cleanup_component_debugfs will debugfs_remove_recursive
the component->debugfs_root, so adsp doesn't need to also
remove the same entry.
By doing that adsp also creates a race with core component,
which causes a NULL pointer dereference

Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20210728104416.636591-1-tanureal@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm_adsp.c

index 549d98241daec1ce6e6c22e19772ac6209b57613..fe15cbc7bcafdcd384859c2168fa57e3653ee5ec 100644 (file)
@@ -747,7 +747,6 @@ static void wm_adsp2_init_debugfs(struct wm_adsp *dsp,
 static void wm_adsp2_cleanup_debugfs(struct wm_adsp *dsp)
 {
        wm_adsp_debugfs_clear(dsp);
-       debugfs_remove_recursive(dsp->debugfs_root);
 }
 #else
 static inline void wm_adsp2_init_debugfs(struct wm_adsp *dsp,