use reference instead of value in function parameter

Change-Id: Ifbd7f263e1a6bcbf563b8cb53a77eacffdb2f07e

diff --git a/src/include/languages.h b/src/include/languages.h
index d9b3173..3ff1886 100644 (file)
--- a/src/include/languages.h
+++ b/src/include/languages.h
@@ -99,7 +99,7 @@ public:
 
     static sclboolean set_language_enabled(const sclchar *name, sclboolean enabled);
     static sclboolean set_language_enabled_temporarily(const sclchar *name, sclboolean enabled_temporarily);
-    static sclboolean set_enabled_languages(std::vector<std::string> languages, sclboolean enabled);
+    static sclboolean set_enabled_languages(const std::vector<std::string> &languages, sclboolean enabled);
     static sclboolean set_all_languages_enabled(sclboolean enabled);
 
     static const sclchar* get_current_language();

diff --git a/src/languages.cpp b/src/languages.cpp
index 1e02919..0fd1ea3 100644 (file)
--- a/src/languages.cpp
+++ b/src/languages.cpp
@@ -330,7 +330,7 @@ sclboolean ISELanguageManager::set_language_enabled_temporarily(const sclchar *n
     return ret;
 }
 
-sclboolean ISELanguageManager::set_enabled_languages(std::vector<std::string> languages, sclboolean enabled)
+sclboolean ISELanguageManager::set_enabled_languages(const std::vector<std::string> &languages, sclboolean enabled)
 {
     sclboolean ret = FALSE;
 
@@ -341,9 +341,10 @@ sclboolean ISELanguageManager::set_enabled_languages(std::vector<std::string> la
         /* Otherwise, disable all languages and enable only those described in the config file */
         set_all_languages_enabled(FALSE);
 
-        for (std::vector<std::string>::iterator iter = languages.begin();
-            iter != languages.end() ;std::advance(iter, 1)) {
-                set_language_enabled(iter->c_str(), enabled);
+        std::vector<std::string>::const_iterator citer;
+        for (citer = languages.begin();
+            citer != languages.end(); citer++) {
+                set_language_enabled(citer->c_str(), enabled);
         }
     }