MIPS: Replace setup_irq() by request_irq()
authorafzal mohammed <afzal.mohd.ma@gmail.com>
Thu, 5 Mar 2020 11:57:53 +0000 (17:27 +0530)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Thu, 5 Mar 2020 15:47:35 +0000 (16:47 +0100)
request_irq() is preferred over setup_irq(). Invocations of setup_irq()
occur after memory allocators are ready.

Per tglx[1], setup_irq() existed in olden days when allocators were not
ready by the time early interrupts were initialized.

Hence replace setup_irq() by request_irq().

remove_irq() has been replaced by free_irq() as well.

There were build error's during previous version, couple of which was
reported by kbuild test robot <lkp@intel.com> of which one was reported
by Thomas Bogendoerfer <tsbogend@alpha.franken.de> as well. There were a
few more issues including build errors, those also have been fixed.

[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos

Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
42 files changed:
arch/mips/alchemy/common/time.c
arch/mips/ar7/irq.c
arch/mips/ath25/ar2315.c
arch/mips/ath25/ar5312.c
arch/mips/bcm63xx/irq.c
arch/mips/cobalt/irq.c
arch/mips/dec/setup.c
arch/mips/emma/markeins/irq.c
arch/mips/include/asm/sni.h
arch/mips/jazz/irq.c
arch/mips/kernel/cevt-bcm1480.c
arch/mips/kernel/cevt-ds1287.c
arch/mips/kernel/cevt-gt641xx.c
arch/mips/kernel/cevt-r4k.c
arch/mips/kernel/cevt-sb1250.c
arch/mips/kernel/cevt-txx9.c
arch/mips/kernel/i8253.c
arch/mips/kernel/rtlx-mt.c
arch/mips/kernel/smp.c
arch/mips/lasat/interrupt.c
arch/mips/loongson2ef/common/bonito-irq.c
arch/mips/loongson2ef/common/cs5536/cs5536_mfgpt.c
arch/mips/loongson2ef/fuloong-2e/irq.c
arch/mips/loongson2ef/lemote-2f/irq.c
arch/mips/loongson32/common/irq.c
arch/mips/loongson32/common/time.c
arch/mips/loongson64/hpet.c
arch/mips/mti-malta/malta-int.c
arch/mips/netlogic/xlr/fmn.c
arch/mips/pmcs-msp71xx/msp_irq.c
arch/mips/pmcs-msp71xx/msp_smp.c
arch/mips/pmcs-msp71xx/msp_time.c
arch/mips/ralink/cevt-rt3352.c
arch/mips/sgi-ip22/ip22-eisa.c
arch/mips/sgi-ip22/ip22-int.c
arch/mips/sgi-ip32/ip32-irq.c
arch/mips/sni/a20r.c
arch/mips/sni/irq.c
arch/mips/sni/pcit.c
arch/mips/sni/rm200.c
arch/mips/sni/time.c
arch/mips/vr41xx/common/irq.c

index 3a21a6a..d794ffb 100644 (file)
@@ -72,13 +72,6 @@ static struct clock_event_device au1x_rtcmatch2_clockdev = {
        .cpumask        = cpu_possible_mask,
 };
 
-static struct irqaction au1x_rtcmatch2_irqaction = {
-       .handler        = au1x_rtcmatch2_irq,
-       .flags          = IRQF_TIMER,
-       .name           = "timer",
-       .dev_id         = &au1x_rtcmatch2_clockdev,
-};
-
 static int __init alchemy_time_init(unsigned int m2int)
 {
        struct clock_event_device *cd = &au1x_rtcmatch2_clockdev;
@@ -130,7 +123,9 @@ static int __init alchemy_time_init(unsigned int m2int)
        cd->min_delta_ns = clockevent_delta2ns(9, cd);
        cd->min_delta_ticks = 9;        /* ~0.28ms */
        clockevents_register_device(cd);
-       setup_irq(m2int, &au1x_rtcmatch2_irqaction);
+       if (request_irq(m2int, au1x_rtcmatch2_irq, IRQF_TIMER, "timer",
+                       &au1x_rtcmatch2_clockdev))
+               pr_err("Failed to register timer interrupt\n");
 
        printk(KERN_INFO "Alchemy clocksource installed\n");
 
index 93a331f..f0a7942 100644 (file)
@@ -83,12 +83,6 @@ static struct irq_chip ar7_sec_irq_type = {
        .irq_ack = ar7_ack_sec_irq,
 };
 
-static struct irqaction ar7_cascade_action = {
-       .handler = no_action,
-       .name = "AR7 cascade interrupt",
-       .flags = IRQF_NO_THREAD,
-};
-
 static void __init ar7_irq_init(int base)
 {
        int i;
@@ -116,8 +110,14 @@ static void __init ar7_irq_init(int base)
                                                 handle_level_irq);
        }
 
-       setup_irq(2, &ar7_cascade_action);
-       setup_irq(ar7_irq_base, &ar7_cascade_action);
+       if (request_irq(2, no_action, IRQF_NO_THREAD, "AR7 cascade interrupt",
+                       NULL))
+               pr_err("Failed to request irq 2 (AR7 cascade interrupt)\n");
+       if (request_irq(ar7_irq_base, no_action, IRQF_NO_THREAD,
+                       "AR7 cascade interrupt", NULL)) {
+               pr_err("Failed to request irq %d (AR7 cascade interrupt)\n",
+                      ar7_irq_base);
+       }
        set_c0_status(IE_IRQ0);
 }
 
index 24f6191..e7b53e3 100644 (file)
@@ -64,11 +64,6 @@ static irqreturn_t ar2315_ahb_err_handler(int cpl, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static struct irqaction ar2315_ahb_err_interrupt  = {
-       .handler        = ar2315_ahb_err_handler,
-       .name           = "ar2315-ahb-error",
-};
-
 static void ar2315_misc_irq_handler(struct irq_desc *desc)
 {
        u32 pending = ar2315_rst_reg_read(AR2315_ISR) &
@@ -159,7 +154,9 @@ void __init ar2315_arch_init_irq(void)
                panic("Failed to add IRQ domain");
 
        irq = irq_create_mapping(domain, AR2315_MISC_IRQ_AHB);
-       setup_irq(irq, &ar2315_ahb_err_interrupt);
+       if (request_irq(irq, ar2315_ahb_err_handler, 0, "ar2315-ahb-error",
+                       NULL))
+               pr_err("Failed to register ar2315-ahb-error interrupt\n");
 
        irq_set_chained_handler_and_data(AR2315_IRQ_MISC,
                                         ar2315_misc_irq_handler, domain);
index 47f3e98..42bf2af 100644 (file)
@@ -68,11 +68,6 @@ static irqreturn_t ar5312_ahb_err_handler(int cpl, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static struct irqaction ar5312_ahb_err_interrupt  = {
-       .handler = ar5312_ahb_err_handler,
-       .name    = "ar5312-ahb-error",
-};
-
 static void ar5312_misc_irq_handler(struct irq_desc *desc)
 {
        u32 pending = ar5312_rst_reg_read(AR5312_ISR) &
@@ -154,7 +149,9 @@ void __init ar5312_arch_init_irq(void)
                panic("Failed to add IRQ domain");
 
        irq = irq_create_mapping(domain, AR5312_MISC_IRQ_AHB_PROC);
-       setup_irq(irq, &ar5312_ahb_err_interrupt);
+       if (request_irq(irq, ar5312_ahb_err_handler, 0, "ar5312-ahb-error",
+                       NULL))
+               pr_err("Failed to register ar5312-ahb-error interrupt\n");
 
        irq_set_chained_handler_and_data(AR5312_IRQ_MISC,
                                         ar5312_misc_irq_handler, domain);
index ec694b9..2548013 100644 (file)
@@ -399,26 +399,6 @@ static struct irq_chip bcm63xx_external_irq_chip = {
        .irq_set_type   = bcm63xx_external_irq_set_type,
 };
 
-static struct irqaction cpu_ip2_cascade_action = {
-       .handler        = no_action,
-       .name           = "cascade_ip2",
-       .flags          = IRQF_NO_THREAD,
-};
-
-#ifdef CONFIG_SMP
-static struct irqaction cpu_ip3_cascade_action = {
-       .handler        = no_action,
-       .name           = "cascade_ip3",
-       .flags          = IRQF_NO_THREAD,
-};
-#endif
-
-static struct irqaction cpu_ext_cascade_action = {
-       .handler        = no_action,
-       .name           = "cascade_extirq",
-       .flags          = IRQF_NO_THREAD,
-};
-
 static void bcm63xx_init_irq(void)
 {
        int irq_bits;
@@ -531,7 +511,7 @@ static void bcm63xx_init_irq(void)
 
 void __init arch_init_irq(void)
 {
-       int i;
+       int i, irq;
 
        bcm63xx_init_irq();
        mips_cpu_irq_init();
@@ -544,14 +524,25 @@ void __init arch_init_irq(void)
                                         handle_edge_irq);
 
        if (!is_ext_irq_cascaded) {
-               for (i = 3; i < 3 + ext_irq_count; ++i)
-                       setup_irq(MIPS_CPU_IRQ_BASE + i, &cpu_ext_cascade_action);
+               for (i = 3; i < 3 + ext_irq_count; ++i) {
+                       irq = MIPS_CPU_IRQ_BASE + i;
+                       if (request_irq(irq, no_action, IRQF_NO_THREAD,
+                                       "cascade_extirq", NULL)) {
+                               pr_err("Failed to request irq %d (cascade_extirq)\n",
+                                      irq);
+                       }
+               }
        }
 
-       setup_irq(MIPS_CPU_IRQ_BASE + 2, &cpu_ip2_cascade_action);
+       irq = MIPS_CPU_IRQ_BASE + 2;
+       if (request_irq(irq, no_action, IRQF_NO_THREAD, "cascade_ip2", NULL))
+               pr_err("Failed to request irq %d (cascade_ip2)\n", irq);
 #ifdef CONFIG_SMP
        if (is_ext_irq_cascaded) {
-               setup_irq(MIPS_CPU_IRQ_BASE + 3, &cpu_ip3_cascade_action);
+               irq = MIPS_CPU_IRQ_BASE + 3;
+               if (request_irq(irq, no_action, IRQF_NO_THREAD, "cascade_ip3",
+                               NULL))
+                       pr_err("Failed to request irq %d (cascade_ip3)\n", irq);
                bcm63xx_internal_irq_chip.irq_set_affinity =
                        bcm63xx_internal_set_affinity;
 
index 965c777..ead5ae4 100644 (file)
@@ -45,18 +45,20 @@ asmlinkage void plat_irq_dispatch(void)
                spurious_interrupt();
 }
 
-static struct irqaction cascade = {
-       .handler        = no_action,
-       .name           = "cascade",
-       .flags          = IRQF_NO_THREAD,
-};
-
 void __init arch_init_irq(void)
 {
        mips_cpu_irq_init();
        gt641xx_irq_init();
        init_i8259_irqs();
 
-       setup_irq(GT641XX_CASCADE_IRQ, &cascade);
-       setup_irq(I8259_CASCADE_IRQ, &cascade);
+       if (request_irq(GT641XX_CASCADE_IRQ, no_action, IRQF_NO_THREAD,
+                       "cascade", NULL)) {
+               pr_err("Failed to request irq %d (cascade)\n",
+                      GT641XX_CASCADE_IRQ);
+       }
+       if (request_irq(I8259_CASCADE_IRQ, no_action, IRQF_NO_THREAD,
+                       "cascade", NULL)) {
+               pr_err("Failed to request irq %d (cascade)\n",
+                      I8259_CASCADE_IRQ);
+       }
 }
index 61a0bf1..c8bbac0 100644 (file)
@@ -103,28 +103,8 @@ int_ptr asic_mask_nr_tbl[DEC_MAX_ASIC_INTS][2] = {
 int cpu_fpu_mask = DEC_CPU_IRQ_MASK(DEC_CPU_INR_FPU);
 int *fpu_kstat_irq;
 
-static struct irqaction ioirq = {
-       .handler = no_action,
-       .name = "cascade",
-       .flags = IRQF_NO_THREAD,
-};
-static struct irqaction fpuirq = {
-       .handler = no_action,
-       .name = "fpu",
-       .flags = IRQF_NO_THREAD,
-};
-
-static struct irqaction busirq = {
-       .name = "bus error",
-       .flags = IRQF_NO_THREAD,
-};
-
-static struct irqaction haltirq = {
-       .handler = dec_intr_halt,
-       .name = "halt",
-       .flags = IRQF_NO_THREAD,
-};
-
+static irq_handler_t busirq_handler;
+static unsigned int busirq_flags = IRQF_NO_THREAD;
 
 /*
  * Bus error (DBE/IBE exceptions and bus interrupts) handling setup.
@@ -134,21 +114,21 @@ static void __init dec_be_init(void)
        switch (mips_machtype) {
        case MACH_DS23100:      /* DS2100/DS3100 Pmin/Pmax */
                board_be_handler = dec_kn01_be_handler;
-               busirq.handler = dec_kn01_be_interrupt;
-               busirq.flags |= IRQF_SHARED;
+               busirq_handler = dec_kn01_be_interrupt;
+               busirq_flags |= IRQF_SHARED;
                dec_kn01_be_init();
                break;
        case MACH_DS5000_1XX:   /* DS5000/1xx 3min */
        case MACH_DS5000_XX:    /* DS5000/xx Maxine */
                board_be_handler = dec_kn02xa_be_handler;
-               busirq.handler = dec_kn02xa_be_interrupt;
+               busirq_handler = dec_kn02xa_be_interrupt;
                dec_kn02xa_be_init();
                break;
        case MACH_DS5000_200:   /* DS5000/200 3max */
        case MACH_DS5000_2X0:   /* DS5000/240 3max+ */
        case MACH_DS5900:       /* DS5900 bigmax */
                board_be_handler = dec_ecc_be_handler;
-               busirq.handler = dec_ecc_be_interrupt;
+               busirq_handler = dec_ecc_be_interrupt;
                dec_ecc_be_init();
                break;
        }
@@ -764,20 +744,29 @@ void __init arch_init_irq(void)
                int irq_fpu;
 
                irq_fpu = dec_interrupt[DEC_IRQ_FPU];
-               setup_irq(irq_fpu, &fpuirq);
+               if (request_irq(irq_fpu, no_action, IRQF_NO_THREAD, "fpu",
+                               NULL))
+                       pr_err("Failed to register fpu interrupt\n");
                desc_fpu = irq_to_desc(irq_fpu);
                fpu_kstat_irq = this_cpu_ptr(desc_fpu->kstat_irqs);
        }
-       if (dec_interrupt[DEC_IRQ_CASCADE] >= 0)
-               setup_irq(dec_interrupt[DEC_IRQ_CASCADE], &ioirq);
-
+       if (dec_interrupt[DEC_IRQ_CASCADE] >= 0) {
+               if (request_irq(dec_interrupt[DEC_IRQ_CASCADE], no_action,
+                               IRQF_NO_THREAD, "cascade", NULL))
+                       pr_err("Failed to register cascade interrupt\n");
+       }
        /* Register the bus error interrupt. */
-       if (dec_interrupt[DEC_IRQ_BUS] >= 0 && busirq.handler)
-               setup_irq(dec_interrupt[DEC_IRQ_BUS], &busirq);
-
+       if (dec_interrupt[DEC_IRQ_BUS] >= 0 && busirq_handler) {
+               if (request_irq(dec_interrupt[DEC_IRQ_BUS], busirq_handler,
+                               busirq_flags, "bus error", NULL))
+                       pr_err("Failed to register bus error interrupt\n");
+       }
        /* Register the HALT interrupt. */
-       if (dec_interrupt[DEC_IRQ_HALT] >= 0)
-               setup_irq(dec_interrupt[DEC_IRQ_HALT], &haltirq);
+       if (dec_interrupt[DEC_IRQ_HALT] >= 0) {
+               if (request_irq(dec_interrupt[DEC_IRQ_HALT], dec_intr_halt,
+                               IRQF_NO_THREAD, "halt", NULL))
+                       pr_err("Failed to register halt interrupt\n");
+       }
 }
 
 asmlinkage unsigned int dec_irq_dispatch(unsigned int irq)
index 09427a4..4aebf55 100644 (file)
@@ -153,14 +153,6 @@ void emma2rh_gpio_irq_init(void)
                                              handle_edge_irq, "edge");
 }
 
-static struct irqaction irq_cascade = {
-          .handler = no_action,
-          .flags = IRQF_NO_THREAD,
-          .name = "cascade",
-          .dev_id = NULL,
-          .next = NULL,
-};
-
 /*
  * the first level int-handler will jump here if it is a emma2rh irq
  */
@@ -236,6 +228,7 @@ void emma2rh_irq_dispatch(void)
 void __init arch_init_irq(void)
 {
        u32 reg;
+       int irq;
 
        /* by default, interrupts are disabled. */
        emma2rh_out32(EMMA2RH_BHIF_INT_EN_0, 0);
@@ -272,9 +265,15 @@ void __init arch_init_irq(void)
        mips_cpu_irq_init();
 
        /* setup cascade interrupts */
-       setup_irq(EMMA2RH_IRQ_BASE + EMMA2RH_SW_CASCADE, &irq_cascade);
-       setup_irq(EMMA2RH_IRQ_BASE + EMMA2RH_GPIO_CASCADE, &irq_cascade);
-       setup_irq(MIPS_CPU_IRQ_BASE + 2, &irq_cascade);
+       irq = EMMA2RH_IRQ_BASE + EMMA2RH_SW_CASCADE;
+       if (request_irq(irq, no_action, IRQF_NO_THREAD, "cascade", NULL))
+               pr_err("Failed to request irq %d (cascade)\n", irq);
+       irq = EMMA2RH_IRQ_BASE + EMMA2RH_GPIO_CASCADE;
+       if (request_irq(irq, no_action, IRQF_NO_THREAD, "cascade", NULL))
+               pr_err("Failed to request irq %d (cascade)\n", irq);
+       irq = MIPS_CPU_IRQ_BASE + 2;
+       if (request_irq(irq, no_action, IRQF_NO_THREAD, "cascade", NULL))
+               pr_err("Failed to request irq %d (cascade)\n", irq);
 }
 
 asmlinkage void plat_irq_dispatch(void)
index a107201..7dfa297 100644 (file)
@@ -11,6 +11,8 @@
 #ifndef __ASM_SNI_H
 #define __ASM_SNI_H
 
+#include <linux/irqreturn.h>
+
 extern unsigned int sni_brd_type;
 
 #define SNI_BRD_10                2
@@ -239,6 +241,6 @@ static inline int sni_eisa_root_init(void)
 
 /* common irq stuff */
 extern void (*sni_hwint)(void);
-extern struct irqaction sni_isa_irq;
+extern irqreturn_t sni_isa_irq_handler(int dummy, void *p);
 
 #endif /* __ASM_SNI_H */
index 5d6828b..04b9c40 100644 (file)
@@ -125,24 +125,18 @@ static irqreturn_t r4030_timer_interrupt(int irq, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static struct irqaction r4030_timer_irqaction = {
-       .handler        = r4030_timer_interrupt,
-       .flags          = IRQF_TIMER,
-       .name           = "R4030 timer",
-};
-
 void __init plat_time_init(void)
 {
        struct clock_event_device *cd = &r4030_clockevent;
-       struct irqaction *action = &r4030_timer_irqaction;
        unsigned int cpu = smp_processor_id();
 
        BUG_ON(HZ != 100);
 
        cd->cpumask             = cpumask_of(cpu);
        clockevents_register_device(cd);
-       action->dev_id = cd;
-       setup_irq(JAZZ_TIMER_IRQ, action);
+       if (request_irq(JAZZ_TIMER_IRQ, r4030_timer_interrupt, IRQF_TIMER,
+                       "R4030 timer", cd))
+               pr_err("Failed to register R4030 timer interrupt\n");
 
        /*
         * Set clock to 100Hz.
index b3e8c11..d39a296 100644 (file)
@@ -91,16 +91,15 @@ static irqreturn_t sibyte_counter_handler(int irq, void *dev_id)
 }
 
 static DEFINE_PER_CPU(struct clock_event_device, sibyte_hpt_clockevent);
-static DEFINE_PER_CPU(struct irqaction, sibyte_hpt_irqaction);
 static DEFINE_PER_CPU(char [18], sibyte_hpt_name);
 
 void sb1480_clockevent_init(void)
 {
        unsigned int cpu = smp_processor_id();
        unsigned int irq = K_BCM1480_INT_TIMER_0 + cpu;
-       struct irqaction *action = &per_cpu(sibyte_hpt_irqaction, cpu);
        struct clock_event_device *cd = &per_cpu(sibyte_hpt_clockevent, cpu);
        unsigned char *name = per_cpu(sibyte_hpt_name, cpu);
+       unsigned long flags =  IRQF_PERCPU | IRQF_TIMER;
 
        BUG_ON(cpu > 3);        /* Only have 4 general purpose timers */
 
@@ -133,11 +132,7 @@ void sb1480_clockevent_init(void)
 
        bcm1480_unmask_irq(cpu, irq);
 
-       action->handler = sibyte_counter_handler;
-       action->flags   = IRQF_PERCPU | IRQF_TIMER;
-       action->name    = name;
-       action->dev_id  = cd;
-
        irq_set_affinity(irq, cpumask_of(cpu));
-       setup_irq(irq, action);
+       if (request_irq(irq, sibyte_counter_handler, flags, name, cd))
+               pr_err("Failed to request irq %d (%s)\n", irq, name);
 }
index 1e1edab..9a47fbc 100644 (file)
@@ -100,14 +100,9 @@ static irqreturn_t ds1287_interrupt(int irq, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static struct irqaction ds1287_irqaction = {
-       .handler        = ds1287_interrupt,
-       .flags          = IRQF_PERCPU | IRQF_TIMER,
-       .name           = "ds1287",
-};
-
 int __init ds1287_clockevent_init(int irq)
 {
+       unsigned long flags = IRQF_PERCPU | IRQF_TIMER;
        struct clock_event_device *cd;
 
        cd = &ds1287_clockevent;
@@ -122,5 +117,5 @@ int __init ds1287_clockevent_init(int irq)
 
        clockevents_register_device(&ds1287_clockevent);
 
-       return setup_irq(irq, &ds1287_irqaction);
+       return request_irq(irq, ds1287_interrupt, flags, "ds1287", NULL);
 }
index eb53548..5b132e8 100644 (file)
@@ -120,12 +120,6 @@ static irqreturn_t gt641xx_timer0_interrupt(int irq, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static struct irqaction gt641xx_timer0_irqaction = {
-       .handler        = gt641xx_timer0_interrupt,
-       .flags          = IRQF_PERCPU | IRQF_TIMER,
-       .name           = "gt641xx_timer0",
-};
-
 static int __init gt641xx_timer0_clockevent_init(void)
 {
        struct clock_event_device *cd;
@@ -146,6 +140,7 @@ static int __init gt641xx_timer0_clockevent_init(void)
 
        clockevents_register_device(&gt641xx_timer0_clockevent);
 
-       return setup_irq(GT641XX_TIMER0_IRQ, &gt641xx_timer0_irqaction);
+       return request_irq(GT641XX_TIMER0_IRQ, gt641xx_timer0_interrupt,
+                          IRQF_PERCPU | IRQF_TIMER, "gt641xx_timer0", NULL);
 }
 arch_initcall(gt641xx_timer0_clockevent_init);
index dd6a18b..64e917d 100644 (file)
@@ -252,6 +252,7 @@ unsigned int __weak get_c0_compare_int(void)
 
 int r4k_clockevent_init(void)
 {
+       unsigned long flags = IRQF_PERCPU | IRQF_TIMER | IRQF_SHARED;
        unsigned int cpu = smp_processor_id();
        struct clock_event_device *cd;
        unsigned int irq, min_delta;
@@ -291,7 +292,8 @@ int r4k_clockevent_init(void)
 
        cp0_timer_irq_installed = 1;
 
-       setup_irq(irq, &c0_compare_irqaction);
+       if (request_irq(irq, c0_compare_interrupt, flags, "timer", NULL))
+               pr_err("Failed to request irq %d (timer)\n", irq);
 
        return 0;
 }
index e1a0860..0451273 100644 (file)
@@ -90,16 +90,15 @@ static irqreturn_t sibyte_counter_handler(int irq, void *dev_id)
 }
 
 static DEFINE_PER_CPU(struct clock_event_device, sibyte_hpt_clockevent);
-static DEFINE_PER_CPU(struct irqaction, sibyte_hpt_irqaction);
 static DEFINE_PER_CPU(char [18], sibyte_hpt_name);
 
 void sb1250_clockevent_init(void)
 {
        unsigned int cpu = smp_processor_id();
        unsigned int irq = K_INT_TIMER_0 + cpu;
-       struct irqaction *action = &per_cpu(sibyte_hpt_irqaction, cpu);
        struct clock_event_device *cd = &per_cpu(sibyte_hpt_clockevent, cpu);
        unsigned char *name = per_cpu(sibyte_hpt_name, cpu);
+       unsigned long flags = IRQF_PERCPU | IRQF_TIMER;
 
        /* Only have 4 general purpose timers, and we use last one as hpt */
        BUG_ON(cpu > 2);
@@ -133,11 +132,7 @@ void sb1250_clockevent_init(void)
 
        sb1250_unmask_irq(cpu, irq);
 
-       action->handler = sibyte_counter_handler;
-       action->flags   = IRQF_PERCPU | IRQF_TIMER;
-       action->name    = name;
-       action->dev_id  = cd;
-
        irq_set_affinity(irq, cpumask_of(cpu));
-       setup_irq(irq, action);
+       if (request_irq(irq, sibyte_counter_handler, flags, name, cd))
+               pr_err("Failed to request irq %d (%s)\n", irq, name);
 }
index 7b17c8f..5709469 100644 (file)
@@ -174,13 +174,6 @@ static irqreturn_t txx9tmr_interrupt(int irq, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static struct irqaction txx9tmr_irq = {
-       .handler        = txx9tmr_interrupt,
-       .flags          = IRQF_PERCPU | IRQF_TIMER,
-       .name           = "txx9tmr",
-       .dev_id         = &txx9_clock_event_device,
-};
-
 void __init txx9_clockevent_init(unsigned long baseaddr, int irq,
                                 unsigned int imbusclk)
 {
@@ -202,7 +195,9 @@ void __init txx9_clockevent_init(unsigned long baseaddr, int irq,
        cd->irq = irq;
        cd->cpumask = cpumask_of(0),
        clockevents_register_device(cd);
-       setup_irq(irq, &txx9tmr_irq);
+       if (request_irq(irq, txx9tmr_interrupt, IRQF_PERCPU | IRQF_TIMER,
+                       "txx9tmr", &txx9_clock_event_device))
+               pr_err("Failed to request irq %d (txx9tmr)\n", irq);
        printk(KERN_INFO "TXx9: clockevent device at 0x%lx, irq %d\n",
               baseaddr, irq);
 }
index df7ddd2..ca21210 100644 (file)
@@ -18,16 +18,13 @@ static irqreturn_t timer_interrupt(int irq, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static struct irqaction irq0  = {
-       .handler = timer_interrupt,
-       .flags = IRQF_NOBALANCING | IRQF_TIMER,
-       .name = "timer"
-};
-
 void __init setup_pit_timer(void)
 {
+       unsigned long flags = IRQF_NOBALANCING | IRQF_TIMER;
+
        clockevent_i8253_init(true);
-       setup_irq(0, &irq0);
+       if (request_irq(0, timer_interrupt, flags, "timer", NULL))
+               pr_err("Failed to request irq 0 (timer)\n");
 }
 
 static int __init init_pit_clocksource(void)
index cb95470..38c6925 100644 (file)
@@ -51,11 +51,6 @@ static irqreturn_t rtlx_interrupt(int irq, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static struct irqaction rtlx_irq = {
-       .handler        = rtlx_interrupt,
-       .name           = "RTLX",
-};
-
 static int rtlx_irq_num = MIPS_CPU_IRQ_BASE + MIPS_CPU_RTLX_IRQ;
 
 void _interrupt_sp(void)
@@ -124,8 +119,7 @@ int __init rtlx_module_init(void)
                goto out_class;
        }
 
-       rtlx_irq.dev_id = rtlx;
-       err = setup_irq(rtlx_irq_num, &rtlx_irq);
+       err = request_irq(rtlx_irq_num, rtlx_interrupt, 0, "RTLX", rtlx);
        if (err)
                goto out_class;
 
index f510c00..d0e911f 100644 (file)
@@ -207,25 +207,13 @@ static irqreturn_t ipi_call_interrupt(int irq, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static struct irqaction irq_resched = {
-       .handler        = ipi_resched_interrupt,
-       .flags          = IRQF_PERCPU,
-       .name           = "IPI resched"
-};
-
-static struct irqaction irq_call = {
-       .handler        = ipi_call_interrupt,
-       .flags          = IRQF_PERCPU,
-       .name           = "IPI call"
-};
-
-static void smp_ipi_init_one(unsigned int virq,
-                                   struct irqaction *action)
+static void smp_ipi_init_one(unsigned int virq, const char *name,
+                            irq_handler_t handler)
 {
        int ret;
 
        irq_set_handler(virq, handle_percpu_irq);
-       ret = setup_irq(virq, action);
+       ret = request_irq(virq, handler, IRQF_PERCPU, name, NULL);
        BUG_ON(ret);
 }
 
@@ -278,12 +266,15 @@ int mips_smp_ipi_allocate(const struct cpumask *mask)
                int cpu;
 
                for_each_cpu(cpu, mask) {
-                       smp_ipi_init_one(call_virq + cpu, &irq_call);
-                       smp_ipi_init_one(sched_virq + cpu, &irq_resched);
+                       smp_ipi_init_one(call_virq + cpu, "IPI call",
+                                        ipi_call_interrupt);
+                       smp_ipi_init_one(sched_virq + cpu, "IPI resched",
+                                        ipi_resched_interrupt);
                }
        } else {
-               smp_ipi_init_one(call_virq, &irq_call);
-               smp_ipi_init_one(sched_virq, &irq_resched);
+               smp_ipi_init_one(call_virq, "IPI call", ipi_call_interrupt);
+               smp_ipi_init_one(sched_virq, "IPI resched",
+                                ipi_resched_interrupt);
        }
 
        return 0;
@@ -311,8 +302,8 @@ int mips_smp_ipi_free(const struct cpumask *mask)
                int cpu;
 
                for_each_cpu(cpu, mask) {
-                       remove_irq(call_virq + cpu, &irq_call);
-                       remove_irq(sched_virq + cpu, &irq_resched);
+                       free_irq(call_virq + cpu, NULL);
+                       free_irq(sched_virq + cpu, NULL);
                }
        }
        irq_destroy_ipi(call_virq, mask);
index 0f3a897..7965bbd 100644 (file)
@@ -90,14 +90,9 @@ asmlinkage void plat_irq_dispatch(void)
        }
 }
 
-static struct irqaction cascade = {
-       .handler        = no_action,
-       .name           = "cascade",
-       .flags          = IRQF_NO_THREAD,
-};
-
 void __init arch_init_irq(void)
 {
+       int irq = LASAT_CASCADE_IRQ;
        int i;
 
        if (IS_LASAT_200()) {
@@ -119,5 +114,6 @@ void __init arch_init_irq(void)
        for (i = LASAT_IRQ_BASE; i <= LASAT_IRQ_END; i++)
                irq_set_chip_and_handler(i, &lasat_irq_type, handle_level_irq);
 
-       setup_irq(LASAT_CASCADE_IRQ, &cascade);
+       if (request_irq(irq, no_action, IRQF_NO_THREAD, "cascade", NULL))
+               pr_err("Failed to request irq %d (cascade)\n", irq);
 }
index 82352cc..c06ad41 100644 (file)
@@ -30,11 +30,6 @@ static struct irq_chip bonito_irq_type = {
        .irq_unmask     = bonito_irq_enable,
 };
 
-static struct irqaction __maybe_unused dma_timeout_irqaction = {
-       .handler        = no_action,
-       .name           = "dma_timeout",
-};
-
 void bonito_irq_init(void)
 {
        u32 i;
@@ -44,6 +39,8 @@ void bonito_irq_init(void)
                                         handle_level_irq);
 
 #ifdef CONFIG_CPU_LOONGSON2E
-       setup_irq(LOONGSON_IRQ_BASE + 10, &dma_timeout_irqaction);
+       i = LOONGSON_IRQ_BASE + 10;
+       if (request_irq(i, no_action, 0, "dma_timeout", NULL))
+               pr_err("Failed to request irq %d (dma_timeout)\n", i);
 #endif
 }
index 30af1b7..f21a540 100644 (file)
@@ -100,12 +100,6 @@ static irqreturn_t timer_interrupt(int irq, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static struct irqaction irq5 = {
-       .handler = timer_interrupt,
-       .flags = IRQF_NOBALANCING | IRQF_TIMER,
-       .name = "timer"
-};
-
 /*
  * Initialize the conversion factor and the min/max deltas of the clock event
  * structure and register the clock event source with the framework.
@@ -134,7 +128,9 @@ void __init setup_mfgpt0_timer(void)
 
        clockevents_register_device(cd);
 
-       setup_irq(CS5536_MFGPT_INTR, &irq5);
+       if (request_irq(CS5536_MFGPT_INTR, timer_interrupt,
+                       IRQF_NOBALANCING | IRQF_TIMER, "timer", NULL))
+               pr_err("Failed to register timer interrupt\n");
 }
 
 /*
index 32278e7..305aa2e 100644 (file)
@@ -35,14 +35,10 @@ asmlinkage void mach_irq_dispatch(unsigned int pending)
                spurious_interrupt();
 }
 
-static struct irqaction cascade_irqaction = {
-       .handler = no_action,
-       .name = "cascade",
-       .flags = IRQF_NO_THREAD,
-};
-
 void __init mach_init_irq(void)
 {
+       int irq;
+
        /* init all controller
         *   0-15         ------> i8259 interrupt
         *   16-23        ------> mips cpu interrupt
@@ -59,7 +55,11 @@ void __init mach_init_irq(void)
        bonito_irq_init();
 
        /* bonito irq at IP2 */
-       setup_irq(MIPS_CPU_IRQ_BASE + 2, &cascade_irqaction);
+       irq = MIPS_CPU_IRQ_BASE + 2;
+       if (request_irq(irq, no_action, IRQF_NO_THREAD, "cascade", NULL))
+               pr_err("Failed to request irq %d (cascade)\n", irq);
        /* 8259 irq at IP5 */
-       setup_irq(MIPS_CPU_IRQ_BASE + 5, &cascade_irqaction);
+       irq = MIPS_CPU_IRQ_BASE + 5;
+       if (request_irq(irq, no_action, IRQF_NO_THREAD, "cascade", NULL))
+               pr_err("Failed to request irq %d (cascade)\n", irq);
 }
index c58a044..34e15e8 100644 (file)
@@ -90,18 +90,6 @@ static irqreturn_t ip6_action(int cpl, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static struct irqaction ip6_irqaction = {
-       .handler = ip6_action,
-       .name = "cascade",
-       .flags = IRQF_SHARED | IRQF_NO_THREAD,
-};
-
-static struct irqaction cascade_irqaction = {
-       .handler = no_action,
-       .name = "cascade",
-       .flags = IRQF_NO_THREAD | IRQF_NO_SUSPEND,
-};
-
 void __init mach_init_irq(void)
 {
        /* init all controller
@@ -120,7 +108,11 @@ void __init mach_init_irq(void)
        bonito_irq_init();
 
        /* setup north bridge irq (bonito) */
-       setup_irq(LOONGSON_NORTH_BRIDGE_IRQ, &ip6_irqaction);
+       if (request_irq(LOONGSON_NORTH_BRIDGE_IRQ, ip6_action,
+                       IRQF_SHARED | IRQF_NO_THREAD, "cascade", NULL))
+               pr_err("Failed to register north bridge cascade interrupt\n");
        /* setup source bridge irq (i8259) */
-       setup_irq(LOONGSON_SOUTH_BRIDGE_IRQ, &cascade_irqaction);
+       if (request_irq(LOONGSON_SOUTH_BRIDGE_IRQ, no_action,
+                       IRQF_NO_THREAD | IRQF_NO_SUSPEND, "cascade", NULL))
+               pr_err("Failed to register south bridge cascade interrupt\n");
 }
index 168d221..9a50070 100644 (file)
@@ -149,12 +149,6 @@ asmlinkage void plat_irq_dispatch(void)
 
 }
 
-static struct irqaction cascade_irqaction = {
-       .handler = no_action,
-       .name = "cascade",
-       .flags = IRQF_NO_THREAD,
-};
-
 static void __init ls1x_irq_init(int base)
 {
        int n;
@@ -176,12 +170,17 @@ static void __init ls1x_irq_init(int base)
                                         handle_level_irq);
        }
 
-       setup_irq(INT0_IRQ, &cascade_irqaction);
-       setup_irq(INT1_IRQ, &cascade_irqaction);
-       setup_irq(INT2_IRQ, &cascade_irqaction);
-       setup_irq(INT3_IRQ, &cascade_irqaction);
+       if (request_irq(INT0_IRQ, no_action, IRQF_NO_THREAD, "cascade", NULL))
+               pr_err("Failed to request irq %d (cascade)\n", INT0_IRQ);
+       if (request_irq(INT1_IRQ, no_action, IRQF_NO_THREAD, "cascade", NULL))
+               pr_err("Failed to request irq %d (cascade)\n", INT1_IRQ);
+       if (request_irq(INT2_IRQ, no_action, IRQF_NO_THREAD, "cascade", NULL))
+               pr_err("Failed to request irq %d (cascade)\n", INT2_IRQ);
+       if (request_irq(INT3_IRQ, no_action, IRQF_NO_THREAD, "cascade", NULL))
+               pr_err("Failed to request irq %d (cascade)\n", INT3_IRQ);
 #if defined(CONFIG_LOONGSON1_LS1C)
-       setup_irq(INT4_IRQ, &cascade_irqaction);
+       if (request_irq(INT4_IRQ, no_action, IRQF_NO_THREAD, "cascade", NULL))
+               pr_err("Failed to request irq %d (cascade)\n", INT4_IRQ);
 #endif
 }
 
index 4cc73f7..459b15c 100644 (file)
@@ -176,13 +176,6 @@ static struct clock_event_device ls1x_clockevent = {
        .tick_resume            = ls1x_clockevent_tick_resume,
 };
 
-static struct irqaction ls1x_pwmtimer_irqaction = {
-       .name           = "ls1x-pwmtimer",
-       .handler        = ls1x_clockevent_isr,
-       .dev_id         = &ls1x_clockevent,
-       .flags          = IRQF_PERCPU | IRQF_TIMER,
-};
-
 static void __init ls1x_time_init(void)
 {
        struct clock_event_device *cd = &ls1x_clockevent;
@@ -206,7 +199,10 @@ static void __init ls1x_time_init(void)
        if (ret)
                panic(KERN_ERR "Failed to register clocksource: %d\n", ret);
 
-       setup_irq(LS1X_TIMER_IRQ, &ls1x_pwmtimer_irqaction);
+       if (request_irq(LS1X_TIMER_IRQ, ls1x_clockevent_isr,
+                       IRQF_PERCPU | IRQF_TIMER, "ls1x-pwmtimer",
+                       &ls1x_clockevent))
+               pr_err("Failed to register ls1x-pwmtimer interrupt\n");
 }
 #endif /* CONFIG_CEVT_CSRC_LS1X */
 
index ed15430..e428259 100644 (file)
@@ -187,12 +187,6 @@ static irqreturn_t hpet_irq_handler(int irq, void *data)
        return IRQ_NONE;
 }
 
-static struct irqaction hpet_irq = {
-       .handler = hpet_irq_handler,
-       .flags = IRQF_NOBALANCING | IRQF_TIMER,
-       .name = "hpet",
-};
-
 /*
  * hpet address assignation and irq setting should be done in bios.
  * but pmon don't do this, we just setup here directly.
@@ -224,6 +218,7 @@ static void hpet_setup(void)
 
 void __init setup_hpet_timer(void)
 {
+       unsigned long flags = IRQF_NOBALANCING | IRQF_TIMER;
        unsigned int cpu = smp_processor_id();
        struct clock_event_device *cd;
 
@@ -247,7 +242,8 @@ void __init setup_hpet_timer(void)
        cd->min_delta_ticks = HPET_MIN_PROG_DELTA;
 
        clockevents_register_device(cd);
-       setup_irq(HPET_T0_IRQ, &hpet_irq);
+       if (request_irq(HPET_T0_IRQ, hpet_irq_handler, flags, "hpet", NULL))
+               pr_err("Failed to request irq %d (hpet)\n", HPET_T0_IRQ);
        pr_info("hpet clock event device register\n");
 }
 
index a840e0c..03d85b2 100644 (file)
@@ -144,12 +144,6 @@ static irqreturn_t corehi_handler(int irq, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static struct irqaction corehi_irqaction = {
-       .handler = corehi_handler,
-       .name = "CoreHi",
-       .flags = IRQF_NO_THREAD,
-};
-
 static msc_irqmap_t msc_irqmap[] __initdata = {
        {MSC01C_INT_TMR,                MSC01_IRQ_EDGE, 0},
        {MSC01C_INT_PCI,                MSC01_IRQ_LEVEL, 0},
@@ -223,5 +217,7 @@ void __init arch_init_irq(void)
                corehi_irq = MIPS_CPU_IRQ_BASE + MIPSCPU_INT_COREHI;
        }
 
-       setup_irq(corehi_irq, &corehi_irqaction);
+       if (request_irq(corehi_irq, corehi_handler, IRQF_NO_THREAD, "CoreHi",
+                       NULL))
+               pr_err("Failed to request irq %d (CoreHi)\n", corehi_irq);
 }
index d428e84..d7db153 100644 (file)
@@ -110,12 +110,6 @@ static irqreturn_t fmn_message_handler(int irq, void *data)
        return IRQ_HANDLED;
 }
 
-struct irqaction fmn_irqaction = {
-       .handler = fmn_message_handler,
-       .flags = IRQF_PERCPU,
-       .name = "fmn",
-};
-
 void xlr_percpu_fmn_init(void)
 {
        struct xlr_fmn_info *cpu_fmn_info;
@@ -195,8 +189,9 @@ void nlm_setup_fmn_irq(void)
 {
        uint32_t flags;
 
-       /* setup irq only once */
-       setup_irq(IRQ_FMN, &fmn_irqaction);
+       /* request irq only once */
+       if (request_irq(IRQ_FMN, fmn_message_handler, IRQF_PERCPU, "fmn", NULL))
+               pr_err("Failed to request irq %d (fmn)\n", IRQ_FMN);
 
        flags = nlm_cop2_enable_irqsave();
        nlm_fmn_setup_intr(IRQ_FMN, (1 << nlm_threads_per_core) - 1);
index 8d53d7a..d525cc9 100644 (file)
@@ -107,18 +107,6 @@ asmlinkage void plat_irq_dispatch(void)
                do_IRQ(MSP_INT_SW1);
 }
 
-static struct irqaction cic_cascade_msp = {
-       .handler = no_action,
-       .name    = "MSP CIC cascade",
-       .flags   = IRQF_NO_THREAD,
-};
-
-static struct irqaction per_cascade_msp = {
-       .handler = no_action,
-       .name    = "MSP PER cascade",
-       .flags   = IRQF_NO_THREAD,
-};
-
 void __init arch_init_irq(void)
 {
        /* assume we'll be using vectored interrupt mode except in UP mode*/
@@ -142,8 +130,12 @@ void __init arch_init_irq(void)
 #endif /* CONFIG_MIPS_MT_SMP */
 #endif /* CONFIG_MIPS_MT */
        /* setup the cascaded interrupts */
-       setup_irq(MSP_INT_CIC, &cic_cascade_msp);
-       setup_irq(MSP_INT_PER, &per_cascade_msp);
+       if (request_irq(MSP_INT_CIC, no_action, IRQF_NO_THREAD,
+                       "MSP CIC cascade", NULL))
+               pr_err("Failed to register MSP CIC cascade interrupt\n");
+       if (request_irq(MSP_INT_PER, no_action, IRQF_NO_THREAD,
+                       "MSP PER cascade", NULL))
+               pr_err("Failed to register MSP PER cascade interrupt\n");
 
 #else
        /*
@@ -153,7 +145,11 @@ void __init arch_init_irq(void)
        msp_slp_irq_init();
 
        /* setup the cascaded SLP/PER interrupts */
-       setup_irq(MSP_INT_SLP, &cic_cascade_msp);
-       setup_irq(MSP_INT_PER, &per_cascade_msp);
+       if (request_irq(MSP_INT_SLP, no_action, IRQF_NO_THREAD,
+                       "MSP CIC cascade", NULL))
+               pr_err("Failed to register MSP CIC cascade interrupt\n");
+       if (request_irq(MSP_INT_PER, no_action, IRQF_NO_THREAD,
+                       "MSP PER cascade", NULL))
+               pr_err("Failed to register MSP PER cascade interrupt\n");
 #endif
 }
index 8f00d26..00092e2 100644 (file)
@@ -38,21 +38,10 @@ static irqreturn_t ipi_call_interrupt(int irq, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static struct irqaction irq_resched = {
-       .handler        = ipi_resched_interrupt,
-       .flags          = IRQF_PERCPU,
-       .name           = "IPI_resched"
-};
-
-static struct irqaction irq_call = {
-       .handler        = ipi_call_interrupt,
-       .flags          = IRQF_PERCPU,
-       .name           = "IPI_call"
-};
-
-void __init arch_init_ipiirq(int irq, struct irqaction *action)
+void __init arch_init_ipiirq(int irq, const char *name, irq_handler_t handler)
 {
-       setup_irq(irq, action);
+       if (request_irq(irq, handler, IRQF_PERCPU, name, NULL))
+               pr_err("Failed to request irq %d (%s)\n", irq, name);
        irq_set_handler(irq, handle_percpu_irq);
 }
 
@@ -60,7 +49,8 @@ void __init msp_vsmp_int_init(void)
 {
        set_vi_handler(MIPS_CPU_IPI_RESCHED_IRQ, ipi_resched_dispatch);
        set_vi_handler(MIPS_CPU_IPI_CALL_IRQ, ipi_call_dispatch);
-       arch_init_ipiirq(MIPS_CPU_IPI_RESCHED_IRQ, &irq_resched);
-       arch_init_ipiirq(MIPS_CPU_IPI_CALL_IRQ, &irq_call);
+       arch_init_ipiirq(MIPS_CPU_IPI_RESCHED_IRQ, "IPI_resched",
+                        ipi_resched_interrupt);
+       arch_init_ipiirq(MIPS_CPU_IPI_CALL_IRQ, "IPI_call", ipi_call_interrupt);
 }
 #endif /* CONFIG_MIPS_MT_SMP */
index d83de01..baf0da8 100644 (file)
@@ -27,7 +27,6 @@
 #define get_current_vpe()   \
        ((read_c0_tcbind() >> TCBIND_CURVPE_SHIFT) & TCBIND_CURVPE)
 
-static struct irqaction timer_vpe1;
 static int tim_installed;
 
 void __init plat_time_init(void)
@@ -77,10 +76,13 @@ void __init plat_time_init(void)
 
 unsigned int get_c0_compare_int(void)
 {
+       unsigned long flags = IRQF_PERCPU | IRQF_TIMER | IRQF_SHARED;
+
        /* MIPS_MT modes may want timer for second VPE */
        if ((get_current_vpe()) && !tim_installed) {
-               memcpy(&timer_vpe1, &c0_compare_irqaction, sizeof(timer_vpe1));
-               setup_irq(MSP_INT_VPE1_TIMER, &timer_vpe1);
+               if (request_irq(MSP_INT_VPE1_TIMER, c0_compare_interrupt, flags,
+                               "timer", NULL))
+                       pr_err("Failed to register timer interrupt\n");
                tim_installed++;
        }
 
index 61a0894..269d487 100644 (file)
@@ -82,12 +82,6 @@ static struct systick_device systick = {
        },
 };
 
-static struct irqaction systick_irqaction = {
-       .handler = systick_interrupt,
-       .flags = IRQF_PERCPU | IRQF_TIMER,
-       .dev_id = &systick.dev,
-};
-
 static int systick_shutdown(struct clock_event_device *evt)
 {
        struct systick_device *sdev;
@@ -95,7 +89,7 @@ static int systick_shutdown(struct clock_event_device *evt)
        sdev = container_of(evt, struct systick_device, dev);
 
        if (sdev->irq_requested)
-               free_irq(systick.dev.irq, &systick_irqaction);
+               free_irq(systick.dev.irq, &systick.dev);
        sdev->irq_requested = 0;
        iowrite32(0, systick.membase + SYSTICK_CONFIG);
 
@@ -104,12 +98,17 @@ static int systick_shutdown(struct clock_event_device *evt)
 
 static int systick_set_oneshot(struct clock_event_device *evt)
 {
+       const char *name = systick.dev.name;
        struct systick_device *sdev;
+       int irq = systick.dev.irq;
 
        sdev = container_of(evt, struct systick_device, dev);
 
-       if (!sdev->irq_requested)
-               setup_irq(systick.dev.irq, &systick_irqaction);
+       if (!sdev->irq_requested) {
+               if (request_irq(irq, systick_interrupt,
+                               IRQF_PERCPU | IRQF_TIMER, name, &systick.dev))
+                       pr_err("Failed to request irq %d (%s)\n", irq, name);
+       }
        sdev->irq_requested = 1;
        iowrite32(CFG_EXT_STK_EN | CFG_CNT_EN,
                  systick.membase + SYSTICK_CONFIG);
@@ -125,7 +124,6 @@ static int __init ralink_systick_init(struct device_node *np)
        if (!systick.membase)
                return -ENXIO;
 
-       systick_irqaction.name = np->name;
        systick.dev.name = np->name;
        clockevents_calc_mult_shift(&systick.dev, SYSTICK_FREQ, 60);
        systick.dev.max_delta_ns = clockevent_delta2ns(0x7fff, &systick.dev);
index a0a7922..f3b0e90 100644 (file)
@@ -92,11 +92,6 @@ static irqreturn_t ip22_eisa_intr(int irq, void *dev_id)
        return IRQ_NONE;
 }
 
-static struct irqaction eisa_action = {
-       .handler        = ip22_eisa_intr,
-       .name           = "EISA",
-};
-
 int __init ip22_eisa_init(void)
 {
        int i, c;
@@ -136,9 +131,8 @@ int __init ip22_eisa_init(void)
 
        init_i8259_irqs();
 
-       /* Cannot use request_irq because of kmalloc not being ready at such
-        * an early stage. Yes, I've been bitten... */
-       setup_irq(SGI_EISA_IRQ, &eisa_action);
+       if (request_irq(SGI_EISA_IRQ, ip22_eisa_intr, 0, "EISA", NULL))
+               pr_err("Failed to request irq %d (EISA)\n", SGI_EISA_IRQ);
 
        EISA_bus = 1;
        return 0;
index 3804895..96798a4 100644 (file)
@@ -159,36 +159,7 @@ static void __irq_entry indy_buserror_irq(void)
        irq_exit();
 }
 
-static struct irqaction local0_cascade = {
-       .handler        = no_action,
-       .flags          = IRQF_NO_THREAD,
-       .name           = "local0 cascade",
-};
-
-static struct irqaction local1_cascade = {
-       .handler        = no_action,
-       .flags          = IRQF_NO_THREAD,
-       .name           = "local1 cascade",
-};
-
-static struct irqaction buserr = {
-       .handler        = no_action,
-       .flags          = IRQF_NO_THREAD,
-       .name           = "Bus Error",
-};
-
-static struct irqaction map0_cascade = {
-       .handler        = no_action,
-       .flags          = IRQF_NO_THREAD,
-       .name           = "mapable0 cascade",
-};
-
 #ifdef USE_LIO3_IRQ
-static struct irqaction map1_cascade = {
-       .handler        = no_action,
-       .flags          = IRQF_NO_THREAD,
-       .name           = "mapable1 cascade",
-};
 #define SGI_INTERRUPTS SGINT_END
 #else
 #define SGI_INTERRUPTS SGINT_LOCAL3
@@ -322,14 +293,24 @@ void __init arch_init_irq(void)
        }
 
        /* vector handler. this register the IRQ as non-sharable */
-       setup_irq(SGI_LOCAL_0_IRQ, &local0_cascade);
-       setup_irq(SGI_LOCAL_1_IRQ, &local1_cascade);
-       setup_irq(SGI_BUSERR_IRQ, &buserr);
+       if (request_irq(SGI_LOCAL_0_IRQ, no_action, IRQF_NO_THREAD,
+                       "local0 cascade", NULL))
+               pr_err("Failed to register local0 cascade interrupt\n");
+       if (request_irq(SGI_LOCAL_1_IRQ, no_action, IRQF_NO_THREAD,
+                       "local1 cascade", NULL))
+               pr_err("Failed to register local1 cascade interrupt\n");
+       if (request_irq(SGI_BUSERR_IRQ, no_action, IRQF_NO_THREAD,
+                       "Bus Error", NULL))
+               pr_err("Failed to register Bus Error interrupt\n");
 
        /* cascade in cascade. i love Indy ;-) */
-       setup_irq(SGI_MAP_0_IRQ, &map0_cascade);
+       if (request_irq(SGI_MAP_0_IRQ, no_action, IRQF_NO_THREAD,
+                       "mapable0 cascade", NULL))
+               pr_err("Failed to register mapable0 cascade interrupt\n");
 #ifdef USE_LIO3_IRQ
-       setup_irq(SGI_MAP_1_IRQ, &map1_cascade);
+       if (request_irq(SGI_MAP_1_IRQ, no_action, IRQF_NO_THREAD,
+                       "mapable1 cascade", NULL))
+               pr_err("Failed to register mapable1 cascade interrupt\n");
 #endif
 
 #ifdef CONFIG_EISA
index a6a0ff7..1bbd5bf 100644 (file)
@@ -111,16 +111,6 @@ static inline void flush_mace_bus(void)
 extern irqreturn_t crime_memerr_intr(int irq, void *dev_id);
 extern irqreturn_t crime_cpuerr_intr(int irq, void *dev_id);
 
-static struct irqaction memerr_irq = {
-       .handler = crime_memerr_intr,
-       .name = "CRIME memory error",
-};
-
-static struct irqaction cpuerr_irq = {
-       .handler = crime_cpuerr_intr,
-       .name = "CRIME CPU error",
-};
-
 /*
  * This is for pure CRIME interrupts - ie not MACE.  The advantage?
  * We get to split the register in half and do faster lookups.
@@ -497,8 +487,12 @@ void __init arch_init_irq(void)
                        break;
                }
        }
-       setup_irq(CRIME_MEMERR_IRQ, &memerr_irq);
-       setup_irq(CRIME_CPUERR_IRQ, &cpuerr_irq);
+       if (request_irq(CRIME_MEMERR_IRQ, crime_memerr_intr, 0,
+                       "CRIME memory error", NULL))
+               pr_err("Failed to register CRIME memory error interrupt\n");
+       if (request_irq(CRIME_CPUERR_IRQ, crime_cpuerr_intr, 0,
+                       "CRIME CPU error", NULL))
+               pr_err("Failed to register CRIME CPU error interrupt\n");
 
 #define ALLINTS (IE_IRQ0 | IE_IRQ1 | IE_IRQ2 | IE_IRQ3 | IE_IRQ4 | IE_IRQ5)
        change_c0_status(ST0_IM, ALLINTS);
index f9407e1..ba966d6 100644 (file)
@@ -222,7 +222,9 @@ void __init sni_a20r_irq_init(void)
                irq_set_chip_and_handler(i, &a20r_irq_type, handle_level_irq);
        sni_hwint = a20r_hwint;
        change_c0_status(ST0_IM, IE_IRQ0);
-       setup_irq(SNI_A20R_IRQ_BASE + 3, &sni_isa_irq);
+       if (request_irq(SNI_A20R_IRQ_BASE + 3, sni_isa_irq_handler,
+                       IRQF_SHARED, "ISA", NULL))
+               pr_err("Failed to register ISA interrupt\n");
 }
 
 void sni_a20r_init(void)
index ac61b90..dec89af 100644 (file)
@@ -27,7 +27,7 @@ asmlinkage void plat_irq_dispatch(void)
 }
 
 /* ISA irq handler */
-static irqreturn_t sni_isa_irq_handler(int dummy, void *p)
+irqreturn_t sni_isa_irq_handler(int dummy, void *p)
 {
        int irq;
 
@@ -39,12 +39,6 @@ static irqreturn_t sni_isa_irq_handler(int dummy, void *p)
        return IRQ_HANDLED;
 }
 
-struct irqaction sni_isa_irq = {
-       .handler = sni_isa_irq_handler,
-       .name = "ISA",
-       .flags = IRQF_SHARED
-};
-
 /*
  * On systems with i8259-style interrupt controllers we assume for
  * driver compatibility reasons interrupts 0 - 15 to be the i8295
index 05bb516..4a850ab 100644 (file)
@@ -244,7 +244,9 @@ void __init sni_pcit_irq_init(void)
        *(volatile u32 *)SNI_PCIT_INT_REG = 0;
        sni_hwint = sni_pcit_hwint;
        change_c0_status(ST0_IM, IE_IRQ1);
-       setup_irq(SNI_PCIT_INT_START + 6, &sni_isa_irq);
+       if (request_irq(SNI_PCIT_INT_START + 6, sni_isa_irq_handler,
+                       IRQF_SHARED, "ISA", NULL))
+               pr_err("Failed to register ISA interrupt\n");
 }
 
 void __init sni_pcit_cplus_irq_init(void)
@@ -257,7 +259,9 @@ void __init sni_pcit_cplus_irq_init(void)
        *(volatile u32 *)SNI_PCIT_INT_REG = 0x40000000;
        sni_hwint = sni_pcit_hwint_cplus;
        change_c0_status(ST0_IM, IE_IRQ0);
-       setup_irq(MIPS_CPU_IRQ_BASE + 3, &sni_isa_irq);
+       if (request_irq(MIPS_CPU_IRQ_BASE + 3, sni_isa_irq_handler,
+                       IRQF_SHARED, "ISA", NULL))
+               pr_err("Failed to register ISA interrupt\n");
 }
 
 void __init sni_pcit_init(void)
index f6fa9af..ba1f2fc 100644 (file)
@@ -356,11 +356,6 @@ void sni_rm200_init_8259A(void)
 /*
  * IRQ2 is cascade interrupt to second interrupt controller
  */
-static struct irqaction sni_rm200_irq2 = {
-       .handler = no_action,
-       .name = "cascade",
-       .flags = IRQF_NO_THREAD,
-};
 
 static struct resource sni_rm200_pic1_resource = {
        .name = "onboard ISA pic1",
@@ -389,12 +384,6 @@ static irqreturn_t sni_rm200_i8259A_irq_handler(int dummy, void *p)
        return IRQ_HANDLED;
 }
 
-struct irqaction sni_rm200_i8259A_irq = {
-       .handler = sni_rm200_i8259A_irq_handler,
-       .name = "onboard ISA",
-       .flags = IRQF_SHARED
-};
-
 void __init sni_rm200_i8259_irqs(void)
 {
        int i;
@@ -417,7 +406,9 @@ void __init sni_rm200_i8259_irqs(void)
                irq_set_chip_and_handler(i, &sni_rm200_i8259A_chip,
                                         handle_level_irq);
 
-       setup_irq(RM200_I8259A_IRQ_BASE + PIC_CASCADE_IR, &sni_rm200_irq2);
+       if (request_irq(RM200_I8259A_IRQ_BASE + PIC_CASCADE_IR, no_action,
+                       IRQF_NO_THREAD, "cascade", NULL))
+               pr_err("Failed to register cascade interrupt\n");
 }
 
 
@@ -481,8 +472,12 @@ void __init sni_rm200_irq_init(void)
                irq_set_chip_and_handler(i, &rm200_irq_type, handle_level_irq);
        sni_hwint = sni_rm200_hwint;
        change_c0_status(ST0_IM, IE_IRQ0);
-       setup_irq(SNI_RM200_INT_START + 0, &sni_rm200_i8259A_irq);
-       setup_irq(SNI_RM200_INT_START + 1, &sni_isa_irq);
+       if (request_irq(SNI_RM200_INT_START + 0, sni_rm200_i8259A_irq_handler,
+                       IRQF_SHARED, "onboard ISA", NULL))
+               pr_err("Failed to register onboard ISA interrupt\n");
+       if (request_irq(SNI_RM200_INT_START + 1, sni_isa_irq_handler,
+                       IRQF_SHARED, "ISA", NULL))
+               pr_err("Failed to register ISA interrupt\n");
 }
 
 void __init sni_rm200_init(void)
index dbace1f..240bb68 100644 (file)
@@ -55,12 +55,6 @@ static irqreturn_t a20r_interrupt(int irq, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static struct irqaction a20r_irqaction = {
-       .handler        = a20r_interrupt,
-       .flags          = IRQF_PERCPU | IRQF_TIMER,
-       .name           = "a20r-timer",
-};
-
 /*
  * a20r platform uses 2 counters to divide the input frequency.
  * Counter 2 output is connected to Counter 0 & 1 input.
@@ -68,13 +62,13 @@ static struct irqaction a20r_irqaction = {
 static void __init sni_a20r_timer_setup(void)
 {
        struct clock_event_device *cd = &a20r_clockevent_device;
-       struct irqaction *action = &a20r_irqaction;
        unsigned int cpu = smp_processor_id();
 
        cd->cpumask             = cpumask_of(cpu);
        clockevents_register_device(cd);
-       action->dev_id = cd;
-       setup_irq(SNI_A20R_IRQ_TIMER, &a20r_irqaction);
+       if (request_irq(SNI_A20R_IRQ_TIMER, a20r_interrupt,
+                       IRQF_PERCPU | IRQF_TIMER, "a20r-timer", cd))
+               pr_err("Failed to register a20r-timer interrupt\n");
 }
 
 #define SNI_8254_TICK_RATE       1193182UL
index 7a826fb..8f68446 100644 (file)
@@ -17,12 +17,6 @@ typedef struct irq_cascade {
 
 static irq_cascade_t irq_cascade[NR_IRQS] __cacheline_aligned;
 
-static struct irqaction cascade_irqaction = {
-       .handler        = no_action,
-       .name           = "cascade",
-       .flags          = IRQF_NO_THREAD,
-};
-
 int cascade_irq(unsigned int irq, int (*get_irq)(unsigned int))
 {
        int retval = 0;
@@ -36,7 +30,8 @@ int cascade_irq(unsigned int irq, int (*get_irq)(unsigned int))
        irq_cascade[irq].get_irq = get_irq;
 
        if (get_irq != NULL) {
-               retval = setup_irq(irq, &cascade_irqaction);
+               retval = request_irq(irq, no_action, IRQF_NO_THREAD,
+                                    "cascade", NULL);
                if (retval < 0)
                        irq_cascade[irq].get_irq = NULL;
        }