fix fixme in elm_toolbar_item_menu_get: no longer modifies a toolbar item

git-svn-id: https://svn.enlightenment.org/svn/e/trunk/elementary@63756 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

diff --git a/src/lib/Elementary.h.in b/src/lib/Elementary.h.in
index aaf2fc1..f56113d 100644 (file)
--- a/src/lib/Elementary.h.in
+++ b/src/lib/Elementary.h.in
@@ -15226,7 +15226,7 @@ extern "C" {
     *
     * @ingroup Toolbar
     */
-   EAPI Evas_Object            *elm_toolbar_item_menu_get(Elm_Toolbar_Item *item) EINA_ARG_NONNULL(1);
+   EAPI Evas_Object            *elm_toolbar_item_menu_get(const Elm_Toolbar_Item *item) EINA_ARG_NONNULL(1);
 
    /**
     * Add a new state to @p item.

diff --git a/src/lib/elm_toolbar.c b/src/lib/elm_toolbar.c
index 3725ac4..5f72c7e 100644 (file)
--- a/src/lib/elm_toolbar.c
+++ b/src/lib/elm_toolbar.c
@@ -1685,14 +1685,11 @@ elm_toolbar_item_cursor_engine_only_get(const Elm_Toolbar_Item *item)
 }
 
 EAPI Evas_Object *
-elm_toolbar_item_menu_get(Elm_Toolbar_Item *item)
+elm_toolbar_item_menu_get(const Elm_Toolbar_Item *item)
 {
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(item, NULL);
    Widget_Data *wd = elm_widget_data_get(WIDGET(item));
-   if (!wd) return NULL;
-   /* FIXME: It's not ok. This function needs to be reviewed. And should
-    * receive a const item */
-   elm_toolbar_item_menu_set(item, 1);
+   if ((!wd) || (!item->menu)) return NULL;
    return item->o_menu;
 }