remoteproc/mtk_scp: Remove timeout variable from scp_ipi_send()
authorAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Wed, 4 Jan 2023 11:53:41 +0000 (12:53 +0100)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Wed, 4 Jan 2023 22:46:17 +0000 (15:46 -0700)
That variable was used twice, but now it's just used once to store
msecs_to_jiffies(wait), fed to wait_event_timeout(): we might as
well remove it for the sake of cleaning up.

This brings no functional changes.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20230104115341.320951-3-angelogioacchino.delregno@collabora.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/remoteproc/mtk_scp_ipi.c

index af47504..fc55df6 100644 (file)
@@ -160,7 +160,6 @@ int scp_ipi_send(struct mtk_scp *scp, u32 id, void *buf, unsigned int len,
                 unsigned int wait)
 {
        struct mtk_share_obj __iomem *send_obj = scp->send_buf;
-       unsigned long timeout;
        u32 val;
        int ret;
 
@@ -197,10 +196,9 @@ int scp_ipi_send(struct mtk_scp *scp, u32 id, void *buf, unsigned int len,
 
        if (wait) {
                /* wait for SCP's ACK */
-               timeout = msecs_to_jiffies(wait);
                ret = wait_event_timeout(scp->ack_wq,
                                         scp->ipi_id_ack[id],
-                                        timeout);
+                                        msecs_to_jiffies(wait));
                scp->ipi_id_ack[id] = false;
                if (WARN(!ret, "scp ipi %d ack time out !", id))
                        ret = -EIO;