mlx5: prevent 64bit divide
authorJakub Kicinski <kuba@kernel.org>
Mon, 18 Oct 2021 17:26:08 +0000 (10:26 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 18 Oct 2021 19:03:04 +0000 (12:03 -0700)
mlx5_tout_ms() returns a u64, we can't directly divide it.
This is not a problem here, @timeout which is the value
that actually matters here is already a ulong, so this
implies storing return value of mlx5_tout_ms() on a ulong
should be fine.

This fixes:

  ERROR: modpost: "__udivdi3" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined!

Fixes: 32def4120e48 ("net/mlx5: Read timeout values from DTOR")
Link: https://lore.kernel.org/r/20211018172608.1069754-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c

index eaca79cc7b9dfefeac617a7e2f887f6c47ae0f30..0b0234f9d694c47a9235171f905cdd987992db78 100644 (file)
@@ -396,13 +396,14 @@ static int fw_reset_event_notifier(struct notifier_block *nb, unsigned long acti
 
 int mlx5_fw_reset_wait_reset_done(struct mlx5_core_dev *dev)
 {
-       unsigned long timeout = msecs_to_jiffies(mlx5_tout_ms(dev, PCI_SYNC_UPDATE));
+       unsigned long pci_sync_update_timeout = mlx5_tout_ms(dev, PCI_SYNC_UPDATE);
+       unsigned long timeout = msecs_to_jiffies(pci_sync_update_timeout);
        struct mlx5_fw_reset *fw_reset = dev->priv.fw_reset;
        int err;
 
        if (!wait_for_completion_timeout(&fw_reset->done, timeout)) {
-               mlx5_core_warn(dev, "FW sync reset timeout after %llu seconds\n",
-                              mlx5_tout_ms(dev, PCI_SYNC_UPDATE) / 1000);
+               mlx5_core_warn(dev, "FW sync reset timeout after %lu seconds\n",
+                              pci_sync_update_timeout / 1000);
                err = -ETIMEDOUT;
                goto out;
        }