dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MSM8974
authorStephan Gerhold <stephan.gerhold@kernkonzept.com>
Thu, 8 Sep 2022 18:24:29 +0000 (20:24 +0200)
committerBjorn Andersson <andersson@kernel.org>
Tue, 27 Dec 2022 16:03:11 +0000 (10:03 -0600)
The "qcom,msm8974-mss-pil" binding is still similar enough to MSM8916
to be covered by the same DT schema. The only difference is the
additional "mss-supply", which can be easily handled using a single
if statement.

Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20220908182433.466908-4-stephan.gerhold@kernkonzept.com
Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt

index ce95e02..d7d05f9 100644 (file)
@@ -18,6 +18,7 @@ properties:
     oneOf:
       - enum:
           - qcom,msm8916-mss-pil
+          - qcom,msm8974-mss-pil
 
       - const: qcom,q6v5-pil
         description: Deprecated, prefer using qcom,msm8916-mss-pil
@@ -76,6 +77,9 @@ properties:
   pll-supply:
     description: PLL proxy supply (control handed over after startup)
 
+  mss-supply:
+    description: MSS power domain supply (only valid for qcom,msm8974-mss-pil)
+
   resets:
     items:
       - description: MSS restart control
@@ -181,6 +185,17 @@ required:
   - smd-edge
 
 allOf:
+  - if:
+      properties:
+        compatible:
+          const: qcom,msm8974-mss-pil
+    then:
+      required:
+        - mss-supply
+    else:
+      properties:
+        mss-supply: false
+
   # Fallbacks for deprecated properties
   - oneOf:
       - required:
index 11862b6..5923c04 100644 (file)
@@ -9,7 +9,6 @@ on the Qualcomm Hexagon core.
        Definition: must be one of:
                    "qcom,ipq8074-wcss-pil"
                    "qcom,qcs404-wcss-pil"
-                   "qcom,msm8974-mss-pil"
                    "qcom,msm8996-mss-pil"
                    "qcom,msm8998-mss-pil"
                    "qcom,sdm845-mss-pil"
@@ -37,7 +36,6 @@ on the Qualcomm Hexagon core.
                    string:
        qcom,ipq8074-wcss-pil:
        qcom,qcs404-wcss-pil:
-       qcom,msm8974-mss-pil:
                    must be "wdog", "fatal", "ready", "handover", "stop-ack"
        qcom,msm8996-mss-pil:
        qcom,msm8998-mss-pil:
@@ -68,8 +66,6 @@ on the Qualcomm Hexagon core.
                    "gcc_axim_cbcr", "lcc_ahbfabric_cbc", "tcsr_lcc_cbc",
                    "lcc_abhs_cbc", "lcc_tcm_slave_cbc", "lcc_abhm_cbc",
                    "lcc_axim_cbc", "lcc_bcr_sleep"
-       qcom,msm8974-mss-pil:
-                   must be "iface", "bus", "mem", "xo"
        qcom,msm8996-mss-pil:
                    must be "iface", "bus", "mem", "xo", "gpll0_mss",
                    "snoc_axi", "mnoc_axi", "pnoc", "qdss"
@@ -107,17 +103,6 @@ should be referenced as follows:
                    by the mpss region
 
 For the compatible string below the following supplies are required:
-  "qcom,msm8974-mss-pil"
-- cx-supply: (deprecated, use power domain instead)
-- mss-supply:
-- mx-supply: (deprecated, use power domain instead)
-- pll-supply:
-       Usage: required
-       Value type: <phandle>
-       Definition: reference to the regulators to be held on behalf of the
-                   booting of the Hexagon core
-
-For the compatible string below the following supplies are required:
   "qcom,qcs404-wcss-pil"
 - cx-supply:
        Usage: required
@@ -144,7 +129,6 @@ For the compatible string below the following supplies are required:
        Definition: The power-domains needed depend on the compatible string:
        qcom,ipq8074-wcss-pil:
                    no power-domain names required
-       qcom,msm8974-mss-pil:
        qcom,msm8996-mss-pil:
        qcom,msm8998-mss-pil:
                    must be "cx", "mx"