ALSA: usb-audio: Drop superfluous interface setup at parsing

We reset each interface that is being parsed for each stream, but this
is superfluous and even can lead to spurious errors.  Since the
interface is set up properly at opening the endpoint for each actual
stream operation, let's drop the superfluous one.

Link: https://lore.kernel.org/r/20220831130021.4762-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/usb/stream.c b/sound/usb/stream.c
index ceb93d798182cfba087848a86609dd23bfbd7ce9..99578e9a8af0718a1c91c4e3e0e605ec053d1440 100644 (file)
--- a/sound/usb/stream.c
+++ b/sound/usb/stream.c
@@ -1221,12 +1221,6 @@ static int __snd_usb_parse_audio_interface(struct snd_usb_audio *chip,
                        if (err < 0)
                                return err;
                }
-
-               /* try to set the interface... */
-               usb_set_interface(chip->dev, iface_no, 0);
-               snd_usb_init_pitch(chip, fp);
-               snd_usb_init_sample_rate(chip, fp, fp->rate_max);
-               usb_set_interface(chip->dev, iface_no, altno);
        }
        return 0;
 }