hid: bigben_probe(): validate report count

[ Upstream commit b94335f899542a0da5fafc38af8edcaf90195843 ]

bigben_probe() does not validate that the output report has the
needed report values in the first field.
A malicious device registering a report with one field and a single
value causes an head OOB write in bigben_worker() when
accessing report_field->value[1] to report_field->value[7].
Use hid_validate_values() which takes care of all the needed checks.

Fixes: 256a90ed9e46 ("HID: hid-bigbenff: driver for BigBen Interactive PS3OFMINIPAD gamepad")
Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
Link: https://lore.kernel.org/r/20230211-bigben-oob-v1-1-d2849688594c@diag.uniroma1.it
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/hid/hid-bigbenff.c b/drivers/hid/hid-bigbenff.c
index 9d6560d..a02cb51 100644 (file)
--- a/drivers/hid/hid-bigbenff.c
+++ b/drivers/hid/hid-bigbenff.c
@@ -371,7 +371,6 @@ static int bigben_probe(struct hid_device *hid,
 {
        struct bigben_device *bigben;
        struct hid_input *hidinput;
-       struct list_head *report_list;
        struct led_classdev *led;
        char *name;
        size_t name_sz;
@@ -396,14 +395,12 @@ static int bigben_probe(struct hid_device *hid,
                return error;
        }
 
-       report_list = &hid->report_enum[HID_OUTPUT_REPORT].report_list;
-       if (list_empty(report_list)) {
+       bigben->report = hid_validate_values(hid, HID_OUTPUT_REPORT, 0, 0, 8);
+       if (!bigben->report) {
                hid_err(hid, "no output report found\n");
                error = -ENODEV;
                goto error_hw_stop;
        }
-       bigben->report = list_entry(report_list->next,
-               struct hid_report, list);
 
        if (list_empty(&hid->inputs)) {
                hid_err(hid, "no inputs found\n");