Fix tc-i386.c -Werror=logical-not-parentheses error

	* config/tc-i386.c (match_template): Remove redundant "!!" testing
	single-bit bitfields.
	(build_modrm_byte): Don't compare single-bit bitfields to "1".

diff --git a/gas/ChangeLog b/gas/ChangeLog
index f355c9c..c5d7db6 100644 (file)
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,9 @@
+2014-09-12  Alan Modra  <amodra@gmail.com>
+
+       * config/tc-i386.c (match_template): Remove redundant "!!" testing
+       single-bit bitfields.
+       (build_modrm_byte): Don't compare single-bit bitfields to "1".
+
 2014-09-09  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
 
        * config/tc-arm.c (arm_cpus): Add cortex-a17.

diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
index ab5a319..5da257f 100644 (file)
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -4709,9 +4709,9 @@ match_template (void)
               && !operand_types[0].bitfield.regymm
               && !operand_types[0].bitfield.regzmm)
              || (!operand_types[t->operands > 1].bitfield.regmmx
-                 && !!operand_types[t->operands > 1].bitfield.regxmm
-                 && !!operand_types[t->operands > 1].bitfield.regymm
-                 && !!operand_types[t->operands > 1].bitfield.regzmm))
+                 && operand_types[t->operands > 1].bitfield.regxmm
+                 && operand_types[t->operands > 1].bitfield.regymm
+                 && operand_types[t->operands > 1].bitfield.regzmm))
          && (t->base_opcode != 0x0fc7
              || t->extension_opcode != 1 /* cmpxchg8b */))
        continue;
@@ -4726,7 +4726,7 @@ match_template (void)
               && ((!operand_types[0].bitfield.regmmx
                    && !operand_types[0].bitfield.regxmm)
                   || (!operand_types[t->operands > 1].bitfield.regmmx
-                      && !!operand_types[t->operands > 1].bitfield.regxmm)))
+                      && operand_types[t->operands > 1].bitfield.regxmm)))
        continue;
 
       /* Do not verify operands when there are none.  */
@@ -6171,8 +6171,8 @@ build_modrm_byte (void)
              op = i.tm.operand_types[vvvv];
              op.bitfield.regmem = 0;
              if ((dest + 1) >= i.operands
-                 || (op.bitfield.reg32 != 1
-                     && !op.bitfield.reg64 != 1
+                 || (!op.bitfield.reg32
+                     && op.bitfield.reg64
                      && !operand_type_equal (&op, &regxmm)
                      && !operand_type_equal (&op, &regymm)
                      && !operand_type_equal (&op, &regzmm)