bus/fsl_mc: Do not rely on caller to provide non NULL mc_io

[ Upstream commit 5026cf605143e764e1785bbf9158559d17f8d260 ]

Before destroying the mc_io, check first that it was
allocated.

Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Acked-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Diana Craciun <diana.craciun@oss.nxp.com>
Link: https://lore.kernel.org/r/20200929085441.17448-11-diana.craciun@oss.nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/staging/fsl-mc/bus/mc-io.c b/drivers/staging/fsl-mc/bus/mc-io.c
index 798c965fe2033da18de82686e76492d4bec69736..3fa6774946fae18a9c45140921454831cbd53c2e 100644 (file)
--- a/drivers/staging/fsl-mc/bus/mc-io.c
+++ b/drivers/staging/fsl-mc/bus/mc-io.c
@@ -167,7 +167,12 @@ error_destroy_mc_io:
  */
 void fsl_destroy_mc_io(struct fsl_mc_io *mc_io)
 {
-       struct fsl_mc_device *dpmcp_dev = mc_io->dpmcp_dev;
+       struct fsl_mc_device *dpmcp_dev;
+
+       if (!mc_io)
+               return;
+
+       dpmcp_dev = mc_io->dpmcp_dev;
 
        if (dpmcp_dev)
                fsl_mc_io_unset_dpmcp(mc_io);