lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3638:30: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
return SendErrorResponse(std::move(ret.takeError()));
^
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3638:30: note: remove std::move call here
return SendErrorResponse(std::move(ret.takeError()));
^~~~~~~~~~ ~
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3622:8: error: unused variable 'cf' [-Werror,-Wunused-variable]
bool cf = packet_str.consume_front("qSaveCore");
std::string path_hint;
StringRef packet_str{packet.GetStringRef()};
- bool cf = packet_str.consume_front("qSaveCore");
- assert(cf);
- if (packet_str.consume_front(";")) {
+ assert(packet_str.startswith("qSaveCore"));
+ if (packet_str.consume_front("qSaveCore;")) {
llvm::SmallVector<llvm::StringRef, 2> fields;
packet_str.split(fields, ';');
llvm::Expected<std::string> ret = m_current_process->SaveCore(path_hint);
if (!ret)
- return SendErrorResponse(std::move(ret.takeError()));
+ return SendErrorResponse(ret.takeError());
StreamString response;
response.PutCString("core-path:");