x86/apic: Hide unused safe_smp_processor_id() on 32-bit UP
authorArnd Bergmann <arnd@arndb.de>
Tue, 25 Jul 2023 13:48:33 +0000 (15:48 +0200)
committerBorislav Petkov (AMD) <bp@alien8.de>
Mon, 31 Jul 2023 09:32:25 +0000 (11:32 +0200)
When CONFIG_SMP is disabled in a 32-bit config, the prototype for
safe_smp_processor_id() is hidden, which causes a W=1 warning:

  arch/x86/kernel/apic/ipi.c:316:5: error: no previous prototype for 'safe_smp_processor_id' [-Werror=missing-prototypes]

Since there are no callers in this configuration, just hide the definition
as well.

  [ bp: Clarify it is a 32-bit config. ]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20230725134837.1534228-2-arnd@kernel.org
arch/x86/kernel/apic/ipi.c

index 2a6509e8c840d19944484f624f805a3e9ae06814..9bfd6e397384545976b5287e94638cc64e1b4753 100644 (file)
@@ -301,6 +301,7 @@ void default_send_IPI_mask_logical(const struct cpumask *cpumask, int vector)
        local_irq_restore(flags);
 }
 
+#ifdef CONFIG_SMP
 /* must come after the send_IPI functions above for inlining */
 static int convert_apicid_to_cpu(int apic_id)
 {
@@ -329,3 +330,4 @@ int safe_smp_processor_id(void)
        return cpuid >= 0 ? cpuid : 0;
 }
 #endif
+#endif