Fix static analysis issues

This patch checks whether the GError variable is nullptr or not.

Change-Id: Ia98fb1c35ce8538e84d253df0c4849bfc190f390
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>

diff --git a/src/modules/boost/src/amd_boost.c b/src/modules/boost/src/amd_boost.c
index 63ff5532fc580e6fd1fc62a6ba1683fbd1e218f7..a94d8cfc601b295bc09661efda09404ea7669185 100644 (file)
--- a/src/modules/boost/src/amd_boost.c
+++ b/src/modules/boost/src/amd_boost.c
@@ -56,8 +56,9 @@ static GDBusConnection *__get_system_conn(void)
 
        __system_conn = g_bus_get_sync(G_BUS_TYPE_SYSTEM, NULL, &err);
        if (__system_conn == NULL) {
-               _E("g_bus_get_sync() is failed: %s", err->message);
-               g_error_free(err);
+               _E("g_bus_get_sync() is failed: %s",
+                               err ? err->message : "");
+               g_clear_error(&err);
                return NULL;
        }
 
@@ -91,7 +92,7 @@ static int __send_cpu_boost_request(int req)
                                NULL,
                                &err) == FALSE) {
                _E("g_dbus_connection_send_message() is failed(%s)",
-                               err->message);
+                               err ? err->message : "");
                res = -1;
        }
 

diff --git a/src/modules/cooldown/src/amd_cooldown.c b/src/modules/cooldown/src/amd_cooldown.c
index 0817c6d19416a9c6d3582e04a384b5ed7a3ed032..a8e3ae06135ef91d846264dcf3b6cbf575e4bb50 100644 (file)
--- a/src/modules/cooldown/src/amd_cooldown.c
+++ b/src/modules/cooldown/src/amd_cooldown.c
@@ -173,8 +173,8 @@ static uid_t __get_caller_uid(GDBusConnection *connection, const char *name)
                        &err);
        if (result == NULL) {
                _E("g_dbus_connection_call_sync() is failed. error(%s)",
-                               err->message);
-               g_error_free(err);
+                               err ? err->message : "");
+               g_clear_error(&err);
                return uid;
        }
 
@@ -257,7 +257,7 @@ static guint __get_owner_id(GDBusConnection *connection,
        if (err) {
                _E("g_dbus_connection_call_sync() is failed. error(%s)",
                                err->message);
-               g_error_free(err);
+               g_clear_error(&err);
                return 0;
        }
 
@@ -302,8 +302,8 @@ static int __init_request_handler(void *user_data)
        __conn = g_bus_get_sync(G_BUS_TYPE_SYSTEM, NULL, &err);
        if (!__conn) {
                _E("g_bus_get_sync() is failed. error(%s)",
-                               err->message);
-               g_error_free(err);
+                               err ? err->message : "");
+               g_clear_error(&err);
                return -1;
        }
 
@@ -327,8 +327,8 @@ static int __init_request_handler(void *user_data)
        g_dbus_node_info_unref(introspection_data);
        if (__registration_id == 0) {
                _E("g_dbus_connection_register_object() is failed. error(%s)",
-                               err->message);
-               g_error_free(err);
+                               err ? err->message : "");
+               g_clear_error(&err);
                return -1;
        }