hugetlb_cgroup: hugetlbfs: use helper macro SZ_1{K,M,G}
authorMiaohe Lin <linmiaohe@huawei.com>
Fri, 29 Jul 2022 08:01:03 +0000 (16:01 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 12 Sep 2022 03:25:52 +0000 (20:25 -0700)
Use helper macro SZ_1K, SZ_1M and SZ_1G to do the size conversion. Minor
readability improvement.

Link: https://lkml.kernel.org/r/20220729080106.12752-3-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Mina Almasry <almasrymina@google.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/hugetlb_cgroup.c

index d16eb00..01a7094 100644 (file)
@@ -675,12 +675,12 @@ static ssize_t hugetlb_cgroup_reset(struct kernfs_open_file *of,
 
 static char *mem_fmt(char *buf, int size, unsigned long hsize)
 {
-       if (hsize >= (1UL << 30))
-               snprintf(buf, size, "%luGB", hsize >> 30);
-       else if (hsize >= (1UL << 20))
-               snprintf(buf, size, "%luMB", hsize >> 20);
+       if (hsize >= SZ_1G)
+               snprintf(buf, size, "%luGB", hsize / SZ_1G);
+       else if (hsize >= SZ_1M)
+               snprintf(buf, size, "%luMB", hsize / SZ_1M);
        else
-               snprintf(buf, size, "%luKB", hsize >> 10);
+               snprintf(buf, size, "%luKB", hsize / SZ_1K);
        return buf;
 }