[GISel]: Print more fallback information when aborting
authorAditya Nandakumar <aditya_nandakumar@apple.com>
Tue, 27 Feb 2018 18:04:23 +0000 (18:04 +0000)
committerAditya Nandakumar <aditya_nandakumar@apple.com>
Tue, 27 Feb 2018 18:04:23 +0000 (18:04 +0000)
Currently when abort is enabled, we get a diagnostic saying "Fallback
path used .... " and the program terminates. To actually figure out what
the reason is, we need to run again with another verbose argument
"-pass-remarks-missed=gisel". Instead, when we are going to abort,
we might as well print expensive remarks.

https://reviews.llvm.org/D43796

llvm-svn: 326215

llvm/lib/CodeGen/GlobalISel/Utils.cpp

index d75964a..b34414b 100644 (file)
@@ -168,7 +168,7 @@ void llvm::reportGISelFailure(MachineFunction &MF, const TargetPassConfig &TPC,
                                     MI.getDebugLoc(), MI.getParent());
   R << Msg;
   // Printing MI is expensive;  only do it if expensive remarks are enabled.
-  if (MORE.allowExtraAnalysis(PassName))
+  if (TPC.isGlobalISelAbortEnabled() || MORE.allowExtraAnalysis(PassName))
     R << ": " << ore::MNV("Inst", MI);
   reportGISelFailure(MF, TPC, MORE, R);
 }