Imported Upstream version 40.6.1 upstream/40.6.1
authorDongHun Kwak <dh0128.kwak@samsung.com>
Mon, 14 Jan 2019 01:44:22 +0000 (10:44 +0900)
committerDongHun Kwak <dh0128.kwak@samsung.com>
Mon, 14 Jan 2019 01:44:22 +0000 (10:44 +0900)
CHANGES.rst
setup.cfg
setup.py
setuptools/dist.py
setuptools/tests/test_dist.py

index 3929703679fa7dd7f9a78c5d7a7b64d3e13e4283..7a3e8743f25a0020ddc74e6a1c98ea8f06d44218 100644 (file)
@@ -1,3 +1,9 @@
+v40.6.1
+-------
+
+* #1590: Fixed regression where packages without ``author`` or ``author_email`` fields generated malformed package metadata.
+
+
 v40.6.0
 -------
 
index fd7e8cc987fa17abd5ee8add99f62bb818f63f1c..9e12b655d531ba17769a2f586cf85b4194b3c3ac 100644 (file)
--- a/setup.cfg
+++ b/setup.cfg
@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 40.6.0
+current_version = 40.6.1
 commit = True
 tag = True
 
index 569730d3cb5f86ba3bcb8da890f10ce577102b20..f24b8e746d4bb27b45c134e9faef1a49f11f3a34 100755 (executable)
--- a/setup.py
+++ b/setup.py
@@ -89,7 +89,7 @@ def pypi_link(pkg_filename):
 
 setup_params = dict(
     name="setuptools",
-    version="40.6.0",
+    version="40.6.1",
     description=(
         "Easily download, build, install, upgrade, and uninstall "
         "Python packages"
index b741c648805a0e6e3acd5c68d7eab98f7c36fc92..7062ae8d8cc66f3f34d44c7c33032c9e1c7b087d 100644 (file)
@@ -138,8 +138,8 @@ def write_pkg_file(self, file):
     write_field('Home-page', self.get_url())
 
     if version < StrictVersion('1.2'):
-        write_field('Author:', self.get_contact())
-        write_field('Author-email:', self.get_contact_email())
+        write_field('Author', self.get_contact())
+        write_field('Author-email', self.get_contact_email())
     else:
         optional_fields = (
             ('Author', 'author'),
index a7f4452b1a8a212e39b4a8dff3283b78b47b8f3a..170d27ed087c72db11714cefe33b0f44ea94753a 100644 (file)
@@ -115,6 +115,20 @@ def __read_test_cases():
             merge_dicts(base_attrs, {
                 'provides_extras': ['foo', 'bar']
         }), marks=pytest.mark.xfail(reason="provides_extras not read")),
+        ('Missing author, missing author e-mail',
+         {'name': 'foo', 'version': '1.0.0'}),
+        ('Missing author',
+         {'name': 'foo',
+          'version': '1.0.0',
+          'author_email': 'snorri@sturluson.name'}),
+        ('Missing author e-mail',
+         {'name': 'foo',
+          'version': '1.0.0',
+          'author': 'Snorri Sturluson'}),
+        ('Missing author',
+         {'name': 'foo',
+          'version': '1.0.0',
+          'author': 'Snorri Sturluson'}),
     ]
 
     return test_cases
@@ -141,6 +155,8 @@ def test_read_metadata(name, attrs):
     tested_attrs = [
         ('name', dist_class.get_name),
         ('version', dist_class.get_version),
+        ('author', dist_class.get_contact),
+        ('author_email', dist_class.get_contact_email),
         ('metadata_version', dist_class.get_metadata_version),
         ('provides', dist_class.get_provides),
         ('description', dist_class.get_description),