Change class members names according to chromium-efl coding style

Several _Ewk_Policy_Decision class members names are typed in camel case style
instead of using underscores

Reviewed by: a1.gomes, d.waslicki, djmix.kim

Change-Id: I19b7541d90aacddd3a863692db8fb4fd7cfdf25a
Signed-off-by: Piotr Krysiewicz <p.krysiewicz@samsung.com>

diff --git a/tizen_src/ewk/efl_integration/private/ewk_policy_decision_private.cc b/tizen_src/ewk/efl_integration/private/ewk_policy_decision_private.cc
index 859692e..97b611d 100644 (file)
--- a/tizen_src/ewk/efl_integration/private/ewk_policy_decision_private.cc
+++ b/tizen_src/ewk/efl_integration/private/ewk_policy_decision_private.cc
@@ -29,12 +29,12 @@ _Ewk_Policy_Decision::_Ewk_Policy_Decision(const GURL &request_url,
                                            PolicyResponseDelegateEfl* delegate)
   : web_view_(NULL)
   , policy_response_delegate_(delegate)
-  , responseHeaders_(NULL)
-  , decisionType_(EWK_POLICY_DECISION_USE)
-  , navigationType_(EWK_POLICY_NAVIGATION_TYPE_OTHER)
-  , isDecided_(false)
-  , isSuspended_(false)
-  , responseStatusCode_(0)
+  , response_headers_(NULL)
+  , decision_type_(EWK_POLICY_DECISION_USE)
+  , navigation_type_(EWK_POLICY_NAVIGATION_TYPE_OTHER)
+  , is_decided_(false)
+  , is_suspended_(false)
+  , response_status_code_(0)
   , type_(POLICY_RESPONSE) {
   DCHECK(delegate);
   DCHECK(request);
@@ -43,14 +43,14 @@ _Ewk_Policy_Decision::_Ewk_Policy_Decision(const GURL &request_url,
 
   ParseUrl(request_url);
   if (response_headers) {
-    responseStatusCode_ = response_headers->response_code();
+    response_status_code_ = response_headers->response_code();
 
     request->GetMimeType(&response_mime_);
 
     if ((!content::IsResourceTypeFrame(resource_type) &&
         !resource_type == content::RESOURCE_TYPE_FAVICON) ||
         (!mime_util::IsSupportedMimeType(response_mime_))) {
-      decisionType_ = EWK_POLICY_DECISION_DOWNLOAD;
+      decision_type_ = EWK_POLICY_DECISION_DOWNLOAD;
     }
 
     if (request_url.has_password() && request_url.has_username())
@@ -64,9 +64,9 @@ _Ewk_Policy_Decision::_Ewk_Policy_Decision(const GURL &request_url,
     void* iter = NULL;
     std::string name;
     std::string value;
-    responseHeaders_ = eina_hash_string_small_new(FreeStringShare);
+    response_headers_ = eina_hash_string_small_new(FreeStringShare);
     while (response_headers->EnumerateHeaderLines(&iter, &name, &value))
-      eina_hash_add(responseHeaders_, name.c_str(), eina_stringshare_add(value.c_str()));
+      eina_hash_add(response_headers_, name.c_str(), eina_stringshare_add(value.c_str()));
   }
 }
 
@@ -75,13 +75,13 @@ _Ewk_Policy_Decision::_Ewk_Policy_Decision(const NavigationPolicyParams &params,
   , navigation_policy_handler_(new NavigationPolicyHandlerEfl(rvh, params))
   , frame_(new _Ewk_Frame(params))
   , cookie_(params.cookie)
-  , httpMethod_(params.httpMethod)
-  , responseHeaders_(NULL)
-  , decisionType_(EWK_POLICY_DECISION_USE)
-  , navigationType_(static_cast<Ewk_Policy_Navigation_Type>(params.type))
-  , isDecided_(false)
-  , isSuspended_(false)
-  , responseStatusCode_(0)
+  , http_method_(params.httpMethod)
+  , response_headers_(NULL)
+  , decision_type_(EWK_POLICY_DECISION_USE)
+  , navigation_type_(static_cast<Ewk_Policy_Navigation_Type>(params.type))
+  , is_decided_(false)
+  , is_suspended_(false)
+  , response_status_code_(0)
   , type_(POLICY_NAVIGATION) {
   ParseUrl(params.url);
   if (!params.auth.isEmpty())
@@ -94,12 +94,12 @@ _Ewk_Policy_Decision::_Ewk_Policy_Decision(EWebView* view,
     content::WebContentsEflDelegate::NewWindowDecideCallback callback)
   : web_view_(view)
   , window_create_callback_(callback)
-  , responseHeaders_(NULL)
-  , decisionType_(EWK_POLICY_DECISION_USE)
-  , navigationType_(EWK_POLICY_NAVIGATION_TYPE_OTHER)
-  , isDecided_(false)
-  , isSuspended_(false)
-  , responseStatusCode_(0)
+  , response_headers_(NULL)
+  , decision_type_(EWK_POLICY_DECISION_USE)
+  , navigation_type_(EWK_POLICY_NAVIGATION_TYPE_OTHER)
+  , is_decided_(false)
+  , is_suspended_(false)
+  , response_status_code_(0)
   , type_(POLICY_NEWWINDOW) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   DCHECK(view);
@@ -114,11 +114,11 @@ _Ewk_Policy_Decision::_Ewk_Policy_Decision(EWebView* view,
 }
 
 _Ewk_Policy_Decision::~_Ewk_Policy_Decision() {
-  eina_hash_free(responseHeaders_);
+  eina_hash_free(response_headers_);
 }
 
 void _Ewk_Policy_Decision::Use() {
-  isDecided_ = true;
+  is_decided_ = true;
   switch (type_) {
     case POLICY_RESPONSE:
       policy_response_delegate_->UseResponse();
@@ -140,7 +140,7 @@ void _Ewk_Policy_Decision::Use() {
 }
 
 void _Ewk_Policy_Decision::Ignore() {
-  isDecided_ = true;
+  is_decided_ = true;
   switch (type_) {
     case _Ewk_Policy_Decision::POLICY_RESPONSE:
       policy_response_delegate_->IgnoreResponse();
@@ -162,7 +162,7 @@ void _Ewk_Policy_Decision::Ignore() {
 }
 
 void _Ewk_Policy_Decision::Download() {
-  isDecided_ = true;
+  is_decided_ = true;
   switch (type_) {
     case _Ewk_Policy_Decision::POLICY_RESPONSE:
       policy_response_delegate_->UseResponse();
@@ -184,9 +184,9 @@ void _Ewk_Policy_Decision::Download() {
 }
 
 bool _Ewk_Policy_Decision::Suspend() {
-  if (!isDecided_ && type_ != _Ewk_Policy_Decision::POLICY_NAVIGATION) {
+  if (!is_decided_ && type_ != _Ewk_Policy_Decision::POLICY_NAVIGATION) {
     // Policy navigation API is currently synchronous - we can't suspend it
-    isSuspended_ = true;
+    is_suspended_ = true;
     return true;
   }
 
@@ -236,8 +236,8 @@ void _Ewk_Policy_Decision::ParseUrl(const GURL& url) {
 void _Ewk_Policy_Decision::SetAuthorizationIfNecessary(const GURL& request_url) {
   // There is no need to check if username or password is empty.
   // It was checked befor in constructor
-  AuthPassword_ = request_url.password();
-  AuthUser_ = request_url.username();
+  auth_password_ = request_url.password();
+  auth_user_ = request_url.username();
 }
 
 void _Ewk_Policy_Decision::SetAuthorizationIfNecessary(const std::string request) {
@@ -245,8 +245,8 @@ void _Ewk_Policy_Decision::SetAuthorizationIfNecessary(const std::string request
   std::transform(type.begin(), type.end(), type.begin(), ::toupper);
 
   if (type.compare(BASIC_AUTHORIZATION)) {
-    AuthUser_.clear();
-    AuthPassword_.clear();
+    auth_user_.clear();
+    auth_password_.clear();
     return;
   }
 
@@ -257,8 +257,8 @@ void _Ewk_Policy_Decision::SetAuthorizationIfNecessary(const std::string request
   if (space == std::string::npos || colon == std::string::npos || colon == request.length())
     return;
 
-  AuthUser_ = request.substr(space + 1, request.length() - colon - 1);
-  AuthPassword_ = request.substr(colon + 1);
+  auth_user_ = request.substr(space + 1, request.length() - colon - 1);
+  auth_password_ = request.substr(colon + 1);
 }
 
 const char* _Ewk_Policy_Decision::GetCookie() const {
@@ -266,11 +266,11 @@ const char* _Ewk_Policy_Decision::GetCookie() const {
 }
 
 const char* _Ewk_Policy_Decision::GetAuthUser() const {
-  return AuthUser_.empty() ? NULL : AuthUser_.c_str();
+  return auth_user_.empty() ? NULL : auth_user_.c_str();
 }
 
 const char* _Ewk_Policy_Decision::GetAuthPassword() const {
-  return AuthPassword_.empty() ? NULL : AuthPassword_.c_str();
+  return auth_password_.empty() ? NULL : auth_password_.c_str();
 }
 
 const char* _Ewk_Policy_Decision::GetUrl() const {
@@ -278,7 +278,7 @@ const char* _Ewk_Policy_Decision::GetUrl() const {
 }
 
 const char* _Ewk_Policy_Decision::GetHttpMethod() const {
-  return httpMethod_.empty() ? NULL : httpMethod_.c_str();
+  return http_method_.empty() ? NULL : http_method_.c_str();
 }
 
 const char* _Ewk_Policy_Decision::GetScheme() const {

diff --git a/tizen_src/ewk/efl_integration/private/ewk_policy_decision_private.h b/tizen_src/ewk/efl_integration/private/ewk_policy_decision_private.h
index 3f26f72..d4bc259 100644 (file)
--- a/tizen_src/ewk/efl_integration/private/ewk_policy_decision_private.h
+++ b/tizen_src/ewk/efl_integration/private/ewk_policy_decision_private.h
@@ -64,9 +64,9 @@ class _Ewk_Policy_Decision {
   void Download();
   bool Suspend();
 
-  bool isDecided() const { return isDecided_; }
-  bool isSuspended() const { return isSuspended_; }
-  Ewk_Policy_Navigation_Type GetNavigationType() const { return navigationType_; }
+  bool isDecided() const { return is_decided_; }
+  bool isSuspended() const { return is_suspended_; }
+  Ewk_Policy_Navigation_Type GetNavigationType() const { return navigation_type_; }
   const char* GetCookie() const;
   const char* GetAuthUser() const;
   const char* GetAuthPassword() const;
@@ -75,9 +75,9 @@ class _Ewk_Policy_Decision {
   const char* GetScheme() const;
   const char* GetHost() const;
   const char* GetResponseMime() const;
-  Ewk_Policy_Decision_Type GetDecisionType() const { return decisionType_; }
-  Eina_Hash* GetResponseHeaders() const { return responseHeaders_; }
-  int GetResponseStatusCode() const { return responseStatusCode_; }
+  Ewk_Policy_Decision_Type GetDecisionType() const { return decision_type_; }
+  Eina_Hash* GetResponseHeaders() const { return response_headers_; }
+  int GetResponseStatusCode() const { return response_status_code_; }
 
   NavigationPolicyHandlerEfl* GetNavigationPolicyHandler() const { return navigation_policy_handler_.get(); }
 
@@ -112,18 +112,18 @@ private:
   content::WebContentsEflDelegate::NewWindowDecideCallback window_create_callback_;
   std::string cookie_;
   std::string url_;
-  std::string httpMethod_;
+  std::string http_method_;
   std::string host_;
   std::string scheme_;
   std::string response_mime_;
-  Eina_Hash* responseHeaders_;
-  Ewk_Policy_Decision_Type decisionType_;
-  Ewk_Policy_Navigation_Type navigationType_;
-  bool isDecided_;
-  bool isSuspended_;
-  int responseStatusCode_;
-  std::string AuthUser_;
-  std::string AuthPassword_;
+  Eina_Hash* response_headers_;
+  Ewk_Policy_Decision_Type decision_type_;
+  Ewk_Policy_Navigation_Type navigation_type_;
+  bool is_decided_;
+  bool is_suspended_;
+  int response_status_code_;
+  std::string auth_user_;
+  std::string auth_password_;
   PolicyType type_;
 };