xfs: remove the syncing argument from xlog_verify_iclog
authorChristoph Hellwig <hch@lst.de>
Sat, 29 Jun 2019 02:27:24 +0000 (19:27 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Sat, 29 Jun 2019 02:27:24 +0000 (19:27 -0700)
The only caller unconditionally passes true here.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_log.c

index 9a6d456..b3d5519 100644 (file)
@@ -103,8 +103,7 @@ STATIC void
 xlog_verify_iclog(
        struct xlog             *log,
        struct xlog_in_core     *iclog,
-       int                     count,
-       bool                    syncing);
+       int                     count);
 STATIC void
 xlog_verify_tail_lsn(
        struct xlog             *log,
@@ -113,7 +112,7 @@ xlog_verify_tail_lsn(
 #else
 #define xlog_verify_dest_ptr(a,b)
 #define xlog_verify_grant_tail(a)
-#define xlog_verify_iclog(a,b,c,d)
+#define xlog_verify_iclog(a,b,c)
 #define xlog_verify_tail_lsn(a,b,c)
 #endif
 
@@ -1921,7 +1920,7 @@ xlog_sync(
        iclog->ic_bp->b_io_length = BTOBB(split ? split : count);
        iclog->ic_bwritecnt = split ? 2 : 1;
 
-       xlog_verify_iclog(log, iclog, count, true);
+       xlog_verify_iclog(log, iclog, count);
        xlog_write_iclog(log, iclog, iclog->ic_bp, bno, need_flush);
 
        if (split) {
@@ -3768,8 +3767,7 @@ STATIC void
 xlog_verify_iclog(
        struct xlog             *log,
        struct xlog_in_core     *iclog,
-       int                     count,
-       bool                    syncing)
+       int                     count)
 {
        xlog_op_header_t        *ophead;
        xlog_in_core_t          *icptr;
@@ -3813,7 +3811,7 @@ xlog_verify_iclog(
                /* clientid is only 1 byte */
                p = &ophead->oh_clientid;
                field_offset = p - base_ptr;
-               if (!syncing || (field_offset & 0x1ff)) {
+               if (field_offset & 0x1ff) {
                        clientid = ophead->oh_clientid;
                } else {
                        idx = BTOBBT((char *)&ophead->oh_clientid - iclog->ic_datap);
@@ -3836,7 +3834,7 @@ xlog_verify_iclog(
                /* check length */
                p = &ophead->oh_len;
                field_offset = p - base_ptr;
-               if (!syncing || (field_offset & 0x1ff)) {
+               if (field_offset & 0x1ff) {
                        op_len = be32_to_cpu(ophead->oh_len);
                } else {
                        idx = BTOBBT((uintptr_t)&ophead->oh_len -