ACPI: NFIT: Import GUID before use
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 13 Dec 2021 20:46:32 +0000 (22:46 +0200)
committerDan Williams <dan.j.williams@intel.com>
Sat, 18 Dec 2021 16:12:40 +0000 (08:12 -0800)
Strictly speaking the comparison between guid_t and raw buffer
is not correct. Import GUID to variable of guid_t type and then
compare.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20211213204632.56735-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/acpi/nfit/core.c

index 7dd80ac..e5d7f2b 100644 (file)
@@ -678,10 +678,12 @@ static const char *spa_type_name(u16 type)
 
 int nfit_spa_type(struct acpi_nfit_system_address *spa)
 {
+       guid_t guid;
        int i;
 
+       import_guid(&guid, spa->range_guid);
        for (i = 0; i < NFIT_UUID_MAX; i++)
-               if (guid_equal(to_nfit_uuid(i), (guid_t *)&spa->range_guid))
+               if (guid_equal(to_nfit_uuid(i), &guid))
                        return i;
        return -1;
 }