spi: imx: Nothing to do in setupxfer when transfer is NULL
authorSascha Hauer <s.hauer@pengutronix.de>
Fri, 2 Jun 2017 05:37:59 +0000 (07:37 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 6 Jun 2017 18:48:22 +0000 (19:48 +0100)
When the spi_transfer given in spi_imx_setupxfer is NULL then
we have nothing to do. Bail out early in this case so that
we do not have to test for t != NULL multiple times later.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-imx.c

index b402530..4b5cd0c 100644 (file)
@@ -217,9 +217,6 @@ static bool spi_imx_can_dma(struct spi_master *master, struct spi_device *spi,
        if (!master->dma_rx)
                return false;
 
-       if (!transfer)
-               return false;
-
        bpw = transfer->bits_per_word;
        if (!bpw)
                bpw = spi->bits_per_word;
@@ -895,8 +892,11 @@ static int spi_imx_setupxfer(struct spi_device *spi,
        struct spi_imx_config config;
        int ret;
 
-       config.bpw = t ? t->bits_per_word : spi->bits_per_word;
-       config.speed_hz  = t ? t->speed_hz : spi->max_speed_hz;
+       if (!t)
+               return 0;
+
+       config.bpw = t->bits_per_word;
+       config.speed_hz  = t->speed_hz;
 
        if (!config.speed_hz)
                config.speed_hz = spi->max_speed_hz;