build: Disable new gcc 8 warning -Wcast-function-type
authorSimon McVittie <smcv@collabora.com>
Mon, 23 Jul 2018 17:20:54 +0000 (18:20 +0100)
committerSimon McVittie <smcv@collabora.com>
Thu, 2 Aug 2018 16:12:26 +0000 (17:12 +0100)
The foreach(list, (DBusForeachFunction) free, NULL) idiom seems too
entrenched to remove it from stable branches.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=107349
Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Thiago Macieira <thiago@kde.org>
configure.ac

index 151cf20..5544cce 100644 (file)
@@ -330,10 +330,14 @@ dnl - we are not going to stop using deprecated functions on a stable
 dnl   branch
 dnl - missing field initializers being 0 is a C feature, not a bug
 dnl - unused-parameter is to make writing callbacks less annoying
+dnl - cast-function-type is for the
+dnl   foreach(list, (DBusForeachFunction) free, NULL) idiom which would
+dnl   be too intrusive to replace in a stable branch
 DISABLE_WARNINGS="$DISABLE_WARNINGS
                   -Wno-deprecated-declarations
                   -Wno-missing-field-initializers
-                  -Wno-unused-parameter"
+                  -Wno-unused-parameter
+                  -Wno-cast-function-type"
 
 if test x$enable_asserts = xno; then
     AC_DEFINE(DBUS_DISABLE_ASSERT,1,[Disable assertion checking])